Repository navigation
Small fixes from the health check: caches, test registration, validation, filter errors [all-db] - #447
Merged
Conversation
… at once over a remote client LanguageResourceCache keeps its miss markers in a capped set, like the session and API key caches: the language and namespace come from any signed-in caller of System.GetLanguage. FormDefinitionLoader fetches the layout layers and the language resources of the fall-back chain concurrently when the client is remote, where each fetch is a round trip; an in-process client keeps fetching one after another, since its calls run on the caller's services.
A filter value that cannot be read as the type of its field now throws InvalidRequestValueException, which the error contract sends as -32602 with its message, instead of an InvalidOperationException that answered -32099 with a fixed message. Public API: adds Polhem.Core.Exceptions.InvalidRequestValueException. Additive only; the conversion it replaces has not shipped in a release.
…p duplicate test registrations
jeff377
enabled auto-merge (squash)
November 12, 2026 14:29
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #441
LanguageResourceCachelimits its miss markers like the other key caches, so a caller cannot grow the cache without bound by asking for languages that do not exist.FormDefinitionLoaderfetches layout and language in parallel when the client is remote; the in-process client keeps fetching them one after another, since it runs on the caller's services.SharedDatabaseStateadds its entries to a copy and replaces the cached instance in one step, so other test classes reading it see either the old or the complete new instance. Duplicate registrations are skipped.HttpUtilities(internal).-32602 InvalidParamswith a message naming the field, instead of-32099with a fixed message. It throws the new publicPolhem.Core.Exceptions.InvalidRequestValueException, anArgumentException. The conversion has not shipped in a release, so the CHANGELOG line and the 1.13.0 notes are updated in place.Public API: adds
InvalidRequestValueException(additive).Verified locally: clean Release build; Definition, Db, Api.Core, Api.Server, Api.Client, Business, ObjectCaching and Core unit tests against the local database containers; doc checks. CI: full (
[all-db]), because the test database registration changes for every provider.