Repository navigation
Bring maintainer documents and comments in line with the code - #446
Merged
Merged
Conversation
ADR-043 and ADR-049 record where the error mapper and its log category moved (ADR-049, 051, 055). ADR-015 and the test bootstrap name the Northwind demo key instead of the removed samples. ADR-033 records that time-of-day values are normalized on the client only, so the sort guarantee holds only for values that went through it. tests/CLAUDE.md documents [WorkloadFact], the template package collection, and that S2699 is a SonarCloud rule. The serialization skill's JSON round trip uses the framework's options; a gotcha names the codec that replaced MessagePackPayloadSerializer. Comments on PolhemMethodPolicy, the anonymous surface test and the customization layer registration describe the current code.
ADR-033 says ToFieldValue never ran on a write path; ADR-043's new entry is in date order and scopes 'of their date' to the whole ADR; ADR-049 records the moved log category as an Amended note; tests/CLAUDE.md points to the WorkloadFact XML doc instead of restating it, marks the template collection as the one non-static definition, and says S2699 is enforced only by the full-mode build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #441
Maintainer documents and code comments that had drifted from the code. No behavior change.
tests/CLAUDE.md: theWorkloadFactsection points to the attribute's XML doc, notes the template package collection, and says that S2699 is enforced only by the full-mode Sonar build.JsonCodec; a stale line in the test/CI gotchas is corrected.PolhemMethodPolicy,PolhemFrameworkServiceCollectionExtensions,TestProcessBootstrapand theAnonymousApiSurfaceTeststext name the types that do the work today.Verified locally:
check-md-links.sh,check-public-docs.sh,check-docs-i18n.sh,check-dependency-map.sh; the pre-commit hook's clean Release build. CI: lite.