Repository navigation
Check the dependency map's package table, and bring the map and the gate messages up to date - #445
Merged
Merged
Conversation
…ate messages up to date check-dependency-map.sh now also compares the external package table with the PackageReference and FrameworkReference items each src project passes on (PrivateAssets all left out; names only). The table gains Mud, Fluent and the WebAssembly host. The map's notes say Polhem.Web.Blazor takes the expression engine, that the WebAssembly host is a plain class library and always remote, and that the Cli reads workbooks through MiniExcel. The POLHEM9001 message, the targets header and the dependency-boundary rule point to the *DependencyGateTests classes instead of naming three of the eight. The Avalonia CLAUDE.md no longer says the WebAssembly host was removed.
…and state its limits Review follow-up: an Include or PrivateAssets value in single quotes, or with spaces around the equals sign, is read; a package named twice in one row is reported; the header states that Condition is not evaluated and that items inside XML comments count. The targets header points to the condition that lists every governed project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #441
check-dependency-map.shnow checks the external package table. The table indocs/*/architecture/dependency-map.mdwas the one part of the map nothing checked, and it had drifted twice (Mud, Fluent and the WebAssembly host were missing). Between newdependency-map:packagesmarkers, the script compares each project's row with thePackageReferenceandFrameworkReferenceitems its csproj passes on to consumers:PrivateAssetsall are left out, as an attribute or a child element, in either case;Includevalues in single quotes or with spaces around=are read;/;(none)means no packages;Conditionis not evaluated, and items inside XML comments count (both report a difference rather than hide one).Checked by breaking it on purpose: removing a row, adding a package that does not exist, duplicating a package, and a temporary csproj with every
Include/PrivateAssetsspelling. Each was reported; the restored tree passes.Map and notes (en and zh-TW): the table gains Mud, Fluent and the WebAssembly host;
Polhem.Web.Blazor(not the Server host) takes the expression engine; the WebAssembly host is a plain class library and always remote; the Cli reads workbooks throughtools/Polhem.Definition.Spreadsheet(MiniExcel); DefineEditor runs asdotnet polhem-define.Gate messages: the POLHEM9001 text, the header of
src/Directory.Build.targetsand.claude/rules/dependency-boundary.mdnamed three of the eight*DependencyGateTestsclasses; they now point to the classes, and the header points to the condition that lists every governed project.src/Polhem.UI.Avalonia/CLAUDE.mdno longer says the WebAssembly host was removed.An adversarial review ran on the script and the documents; its findings are fixed in the second and third commits.
Verified locally:
check-dependency-map.sh, the other documentation checks, and a Release build ofPolhem.Core(the targets file). Lite CI.