Remove parameter "-RemoveExisting" from Add-AzureAD- and M365Group-Members and -Owners #5153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenboll
changed the title
Collaborator
|
Thanks @svenboll , couple more changes. We also need to mark the parameter as obsolete with deprecation message, something like in this PR: https://github.com/pnp/powershell/pull/5146/files Could you do please do that for the cmdlets ? |
svenboll
force-pushed
the
deprecate-removeexisting
branch
2 times, most recently
from
ccfc140 to
7144266
Compare
Author
|
Thanks for your comments and thoughts. I updated the commits. |
Collaborator
|
@svenboll - its not compiling for |
svenboll
force-pushed
the
deprecate-removeexisting
branch
from
80a343d to
72cea69
Compare
svenboll
force-pushed
the
deprecate-removeexisting
branch
from
72cea69 to
7255f2c
Compare
Author
|
fixes missing using class. successfullly build a debug version locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
discussed in #5147
What is in this Pull Request ?
The parameter "-RemoveExisting" was never implemented in functions like "Add-Microsoft365GroupMember|Owner", respectively AzureADGroups.
After the suggestion from @gautamdsheth the parameter is now deprecated and removed.