Credit the chosen community and keep edge weights in the volume totals - #177
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things in
hypergraph_modularity.py.Both
_last_stepvariants pick a target community intobest, setdct_A[v] = best, and then updateVolA[m].mis the loop variable, so the volume is credited to whichever candidate the search happened to end on. On a seeded 30 node hypergraph the returned partition changes once it isVolA[best].VolAandCtrare built withnp.repeat(0, n), which is int64, and then accumulateHG.edges[e].weight. On a hypergraph with weights of 0.5 the volumes come out[0, 3]instead of[2.75, 5.5], because each+= 0.5truncates.np.zeroskeeps them.tests/algorithmsis 41 passing.