Export library as both UMD and ESM #176
Open
+107
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I originally closed as I thought I encountered an issue with the UMD build, however it was due to another local change. Reopening this as I think it is still a good starting point. I am using Vite for my build system, so I have been able to verify the ESM build, however have had some difficulty verifying that the existing UMD build works as expected. Would someone from pnext be able to verify the UMD build works with their existing system? If not, I can dig into the UMD build more, however might be easier verifying with pnext's original systems. |
Contributor
Author
Collaborator
|
We've run prettier recently. It's highly recommended to first run "npm run format:write", commit and rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to export the library in both UMD and ESM format.
Now the build system exports UMD format (index.cjs), ESM format (index.mjs), and types at the root level. Exporting types at the root build level allows IDEs such as VSCode to find the typings when three-loader is used as a git submodule.