Skip to content

Conversation

@piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Mar 13, 2025

Summary

  • Fixes e2e tests that were failing silently on CI due to bad paths, etc
  • Will follow with a PR to make them more robust

Required Reviews

Minimum number of reviews before merge: 1

Copy link
Contributor

@lonerapier lonerapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this.

can we add a test CI for both JSON and HTML as well?

"Content-Type": "application/json"
}
}
"target_method": "GET",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need these now, after the cleanup PR: #515

Copy link
Contributor Author

@piotr-roslaniec piotr-roslaniec Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not in anymore, I may have messed-up a rebase. I will address it later.

@piotr-roslaniec piotr-roslaniec merged commit 0121ffe into main Mar 18, 2025
18 checks passed
@piotr-roslaniec piotr-roslaniec deleted the fix/fixtures branch March 18, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants