feat: Run Playwright scripts #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lonerapier wants to merge 5 commits into main from feat/executor

Contributor

lonerapier commented Mar 11, 2025 •

edited by mattes

Loading

No description provided.


          init playwright

8ab14eb

lonerapier changed the title ~~init playwright~~ feat: executor


          basic script working

ec8a043

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

executor/src/main.rs Outdated Show resolved Hide resolved

mattes reviewed

View reviewed changes

notary/src/main.rs Outdated Show resolved Hide resolved

mattes requested changes

View reviewed changes

Contributor

mattes left a comment

nice work! excited to see this come together.

I left a few thoughts and comments. already iterating slightly on top of the go mvp work.

mattes changed the title ~~feat: executor~~ feat: Run Playwright scripts

Contributor

mattes commented Mar 11, 2025

Maybe executor is too generic for this crate. Can we be more specific? playwright-executor ?

Contributor Author

lonerapier commented Mar 11, 2025

Maybe executor is too generic for this crate. Can we be more specific? playwright-executor ?

Agreed. what about playwright-executor inside executor crate? or you think it should be part of notary only?

My reasoning was this flow can work independent of notary, and can be exetendned further with a separate crate. For example: using chromiumoxide headless runner instead of playwright

lonerapier added 3 commits

March 12, 2025 01:08


          add playwright config and timeout

9422cdd


          start internal listener

266c560


          add env vars

9bc5757

Contributor

mattes commented Mar 12, 2025

Agreed, it can be used independently. Maybe we start a new utils directory?

utils/playwright-executor ?

Contributor Author

lonerapier commented Mar 14, 2025

closing in favor of #564

lonerapier closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet