-
Notifications
You must be signed in to change notification settings - Fork 2
Defer external resources until process initialization #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
toby-coleman
wants to merge
7
commits into
main
Choose a base branch
from
worktree/silver-valley-213f
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
13464cf
Add optional pyomq ZMQ backend
paddor 6a14e89
fix: yield while ZMQ proxy has no pipeline sockets
toby-coleman b5bd5c7
test: cover optional ZMQ backend branches
toby-coleman e3ca366
Merge branch 'main' into pyomq-zmq-backend
toby-coleman c73d3e0
build: include pyomq in test dependencies
toby-coleman 2bc0bfb
Merge remote-tracking branch 'origin/main' into pr-281-latest
toby-coleman 01db9f6
Defer process resource initialization
toby-coleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| """Selects the ZeroMQ Python backend.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import typing as _t | ||
|
|
||
|
|
||
| ZMQ_BACKEND_ENV = "PLUGBOARD_ZMQ_BACKEND" | ||
| ZMQ_BACKEND_PYZMQ = "pyzmq" | ||
| ZMQ_BACKEND_PYOMQ = "pyomq" | ||
| ZMQ_BACKENDS = frozenset({ZMQ_BACKEND_PYZMQ, ZMQ_BACKEND_PYOMQ}) | ||
|
|
||
|
|
||
| class ZMQBackendImportError(ImportError): | ||
| """Raised when the selected ZeroMQ backend cannot be imported.""" | ||
|
|
||
|
|
||
| def _backend_name() -> str: | ||
| backend = os.environ.get(ZMQ_BACKEND_ENV, ZMQ_BACKEND_PYZMQ).strip().lower() | ||
| if not backend: | ||
| return ZMQ_BACKEND_PYZMQ | ||
| if backend not in ZMQ_BACKENDS: | ||
| choices = ", ".join(sorted(ZMQ_BACKENDS)) | ||
| raise ValueError( | ||
| f"Unsupported ZMQ backend {backend!r}. Set {ZMQ_BACKEND_ENV} to one of: {choices}." | ||
| ) | ||
| return backend | ||
|
|
||
|
|
||
| def _load_backend() -> tuple[str, _t.Any, _t.Any]: | ||
| backend = _backend_name() | ||
| try: | ||
| if backend == ZMQ_BACKEND_PYOMQ: | ||
| import pyomq as zmq | ||
| import pyomq.asyncio as zmq_asyncio | ||
| else: | ||
| import zmq | ||
| import zmq.asyncio as zmq_asyncio | ||
| except ImportError as e: | ||
| raise ZMQBackendImportError( | ||
| f"Failed to import {backend!r} ZMQ backend selected by {ZMQ_BACKEND_ENV}." | ||
| ) from e | ||
| return backend, zmq, zmq_asyncio | ||
|
|
||
|
|
||
| zmq_backend, zmq, zmq_asyncio = _load_backend() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When callers instantiate the public
RayChannelclass directly rather than obtaining it throughRayConnector, the actor now remainsNone, sosend(),recv(),close(),maxsize, andis_closedall fail withAttributeErrorunless the caller knows to invoke the newly addedRayChannel.init()first.Channelhas no initialization lifecycle in its interface, and these operations worked immediately after construction before this change; either retain that behavior for direct instances or formally expose and enforce the new lifecycle across the channel API.AGENTS.md reference: AGENTS.md:L140-L145
Useful? React with 👍 / 👎.