fix: process.export broken when state and parameters not explicitly provided#226
Open
fix: process.export broken when state and parameters not explicitly provided#226
process.export broken when state and parameters not explicitly provided#226Conversation
Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken process.export function in plugboard
fix: Mar 9, 2026
process.export broken when state and parameters not explicitly provided
|
Benchmark comparison for |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.dump()fails with a Pydantic validation error whenstateandparametersare omitted atLocalProcessconstruction.Root cause:
ExportMixin._save_args_wrapperwraps bothLocalProcess.__init__andProcess.__init__. WhenLocalProcess.__init__callssuper().__init__(..., parameters=None, state=None), the parent wrapper captures those explicitNonevalues and merges them into__save_args_init__. The export dict then containsparameters=Noneandstate=None, which failProcessArgsSpecvalidation.Changes
plugboard-schemas/plugboard_schemas/process.py: Added_coerce_parametersand_coerce_statefield_validators toProcessArgsSpecto coerceNone→{}andNone→StateBackendSpec()respectively. Consistent withProcessArgsDictwhich already typedstateasNotRequired[StateBackendSpec | None].tests/integration/test_process_builder.py: Addedtest_process_dump_with_default_state_and_parametersto reproduce and validate the fix.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED grep -l state.*None py de/node/bin/grep(dns block)releases.astral.sh/home/REDACTED/.local/bin/uv uv venv .venv --python python3.13 state.*None hemas/state.py k/_temp/ghcca-node/node/bin/grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
process.exportbroken #225🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.