Repository navigation
Run matplotlylib tests in CI - #5794
Open
robertoffmoura wants to merge 2 commits into
Open
robertoffmoura wants to merge 2 commits into
robertoffmoura wants to merge 2 commits into
Conversation
camdecoster
requested changes
Oct 7, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for putting this together! Could you please make a few minor changes?
Contributor
There was a problem hiding this comment.
Could you please drop this update from the PR? Since the change isn't user facing, I don't think the entry is necessary.
Contributor
There was a problem hiding this comment.
Could you please update the action versions to the latest available?
Comment on lines
+187
to
+188
| uv sync --extra dev_core | ||
| uv pip install matplotlib |
Contributor
There was a problem hiding this comment.
I'd like to pin the version of matplotlib using the lock file. Could you add a new entry in pyproject.toml under project.optional-dependencies called dev_matplotlib? Then we can reference that in the CI workflow.
dev_matplotlib = [
"plotly[dev_core]",
"matplotlib",
]
Suggested change
| uv sync --extra dev_core | |
| uv pip install matplotlib | |
| uv lock --check | |
| uv sync --locked --extra dev_matplotlib |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5697. It adds a dedicated test-matplotlylib job to run-pytest.yml that installs matplotlib and runs the tests across all supported Python versions (3.8–3.13)
Historically, the original matplotlylib tests (in tests/test_optional/test_matplotlylib/) were intentionally skipped in 2022 (b7ba00b) because they were failing. When the test_renderer suite (plotly/matplotlylib/tests/test_renderer.py) was added (#5312), it was unintentionally never wired into run-pytest.yml.