Fix stale scattergl error bars on legend toggle#7824
Open
JulienIcon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixes #7773.
This PR fixes stale
scatterglerror bars after toggling trace visibility from the legend when only some traces have error bars.regl-error2dkeeps previous groups when batch entries are omitted, so hidden traces could leave stale error-bar groups behind. The fix sends explicit empty error-bar options for missingerror_x/error_yentries, clearing the corresponding renderer groups.Tests
Added a
scatterglregression test covering mixed traces with and withouterror_y. The test verifies that after toggling visibility, the remaining visible error bars are as expected and that stale renderer groups are cleared.