Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dash/dash-renderer/src/actions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {createAction} from 'redux-actions';
import {addRequestedCallbacks} from './callbacks';
import {getAppState} from '../reducers/constants';
import {getAction} from './constants';
import * as cookie from 'cookie';
import {parseCookie} from 'cookie';
import {validateCallbacksToLayout} from './dependencies';
import {
includeObservers,
Expand Down Expand Up @@ -77,7 +77,7 @@ export function getCSRFHeader(config) {
try {
const tokenName = (config && config.csrf_token_name) || '_csrf_token';
const headerName = (config && config.csrf_header_name) || 'X-CSRFToken';
const cookies = cookie.parse(document.cookie);
const cookies = parseCookie(document.cookie);
const token = cookies[tokenName];
if (!token) {
return {};
Expand Down
21 changes: 21 additions & 0 deletions tests/integration/security/test_csrf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import flask

from dash import Dash, Input, Output, html


def test_csrf001_token_cookie_sent_as_header(dash_duo):
app = Dash(__name__)
app.layout = html.Div([html.Button("go", id="go"), html.Div(id="out")])

@app.server.after_request
def set_token(response):
response.set_cookie("_csrf_token", "tok123")
return response

@app.callback(Output("out", "children"), Input("go", "n_clicks"))
def echo(_):
return flask.request.headers.get("X-CSRFToken", "missing")

dash_duo.start_server(app)
dash_duo.wait_for_text_to_equal("#out", "tok123")
assert dash_duo.get_logs() == []
Loading