Skip to content

fix: Add displayNotifier to Graph config #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 2 commits into from
Apr 10, 2026
+5 −41
Merged

fix: Add displayNotifier to Graph config #3737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf19476
fix: Add `displayNotifier` to Graph config
camdecoster Apr 10, 2026
982e238
Remove schema/config comparison test
camdecoster Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/dash-core-components/src/components/Graph.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,11 @@ PlotlyGraph.propTypes = {
* plot rather than registering them globally.
*/
locales: PropTypes.object,

/**
* Determines whether or not notifier is displayed
*/
displayNotifier: PropTypes.bool,
}),

/**
Expand Down
41 changes: 0 additions & 41 deletions components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from dash import Dash, Input, Output, dcc, html
from dash.exceptions import PreventUpdate
import json
import os
import pytest
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
Expand Down Expand Up @@ -185,43 +183,4 @@ def on_click_update_graph(n_clicks):
time.sleep(1)
dash_dcc.percy_snapshot(f"Tabs-2 rendered ({is_eager})")

# do some extra tests while we're here
# and have access to Graph and plotly.js
check_graph_config_shape(dash_dcc)

assert dash_dcc.get_logs() == []


def check_graph_config_shape(dash_dcc):
config_schema = dash_dcc.driver.execute_script(
"return Plotly.PlotSchema.get().config;"
)
with open(os.path.join(dcc.__path__[0], "metadata.json")) as meta:
graph_meta = json.load(meta)["src/components/Graph.react.js"]
config_prop_shape = graph_meta["props"]["config"]["type"]["value"]

ignored_config = [
"setBackground",
"showSources",
"logging",
"globalTransforms",
"notifyOnLogging",
"role",
"typesetMath",
]

def crawl(schema, props):
for prop_name in props:
assert prop_name in schema

for item_name, item in schema.items():
if item_name in ignored_config:
continue

assert item_name in props
if "valType" not in item:
crawl(item, props[item_name]["value"])

crawl(config_schema, config_prop_shape)

assert dash_dcc.get_logs() == []
Loading