hotfix: lock sklearn to 1.6.1 for backwards compatibility #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Addresses backward compatibility issues by pinning scikit-learn version and adding deprecation support in pyproject.toml.
- Pins scikit-learn to v1.6.1 to prevent breaking changes from v1.7.0 affecting existing models
- Adds
deprecatedpackage v1.2.18 for better deprecation handling - Bumps package version from 0.26.0 to 0.26.2 for hotfix release
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
There was a problem hiding this comment.
Pull Request Overview
This hotfix locks scikit-learn to version 1.6.1 for backwards compatibility, bumps the package version, and adds a new dependency.
- Bumped project version from 0.26.0 to 0.26.2
- Pinned
scikit-learnexactly to 1.6.1 - Added
deprecatedas a new dependency
Comments suppressed due to low confidence (2)
pyproject.toml:3
- Consider updating CHANGELOG.md or release notes to document this hotfix release and explain the version bump.
version = "0.26.2"
pyproject.toml:55
- Verify that the
deprecatedpackage is actually used in the codebase; if it's unused, removing it will keep dependencies lean.
deprecated = "^1.2.18"
# Conflicts: # poetry.lock # pyproject.toml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newest library version
sklearnwas upgraded to1.7.0, which was causing issues loading and using models from earlier versions ofplexe.