Ensures locations can be requested over POST /query endpoint with full parity#6412
Open
apata wants to merge 5 commits into
Open
Ensures locations can be requested over POST /query endpoint with full parity#6412apata wants to merge 5 commits into
apata wants to merge 5 commits into
Conversation
RobertJoonas
approved these changes
May 28, 2026
| ] | ||
| end | ||
|
|
||
| test "filtering by A1 returns only anonymous VPN visitors", %{conn: conn, site: site} do |
Contributor
There was a problem hiding this comment.
Nicely integrated with the location library! 👌 Although I think this specific test does not do anything "new" -- the is filter acts as it would with any other country code filter, and the getting country_name by the code is tested right above.
Perhaps let's update filters in this test to search by country name?
[["contains", "visit:country_name", ["Anonymous"]]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode