Skip to content

Exploration UI refactor#6408

Open
zoldar wants to merge 5 commits into
masterfrom
exploration-ui-refactor
Open

Exploration UI refactor#6408
zoldar wants to merge 5 commits into
masterfrom
exploration-ui-refactor

Conversation

@zoldar
Copy link
Copy Markdown
Contributor

@zoldar zoldar commented May 27, 2026

Changes

This PR attempts to do some gradual refactoring improvements to exploration UI logic.

So far, following changes were made:

  • conversion rate type in funnel and provisional funnel types is now always a string, for consistency as that's how we get it from the backend to avoid float related inaccuracies
  • the rounded percentage helper got removed with a more general round number formatter
  • the selected suggestion is now passed as a single object instead of a collection of fields/arguments
  • ensure stepMaxVisitors is always a numeric value to avoid potential division by zero (TS did not catch that, strangely)
  • always user Number for casting strings to numeric values (instead of parseFloat)

There's definitely potential for more but that's at least some small start.

@apata if you have any free cycles, I'd really appreciate your eyes on this. I'd be keen on going over the exploration UI code together if you'd like to, to provide any missing context or unclear intent.

@zoldar zoldar requested review from aerosol and apata May 27, 2026 12:08
} else {
return number.toFixed(1).replace(/\.0$/, '') + '%'
}
return roundedNumberFormatter(number) + '%'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants