Repository navigation
Release v0.1.3: offer a reload when a tab has no content script - #4
Merged
Merged
Conversation
Tabs opened before install, or left open across an update, have no content script until they reload. The popup called these pages unavailable and disabled its controls, which looks like a broken extension. Offer a reload instead, except on browser store pages or after a reload did not help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2
Tabs opened before App Notes was installed, or left open while it updates, have no content script until they reload. The popup called these pages unavailable and disabled Enable annotations, with no hint that a reload would fix it.
The popup now shows Reload page in that state. Two cases never offer it:
No new permissions. This also bumps the version to 0.1.3, because 0.1.2 is already live and the store needs a higher version. 0.1.3 ships this change and #3.
Testing
bun run release:verifypasses, with 68 tests.chrome://pages, the reload-loop guard, and a normal tab.