Repository navigation
Conversation
darwich6
marked this pull request as ready for review
November 20, 2026 02:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until the API accepts
max_rollouton keyspace create and that change is deployed. Today the create endpoint silently drops unknown params, so this flag would be accepted by the CLI and then do nothing.Adds
--max-rollout(1–32, optional) topscale keyspace create, matchingkeyspace update-settings --max-rollout(#1404).max_rolloutis not sent (omitemptypointer), so the API picks a default based on the shard count.max_rollout.update-settingscommand to apply it. JSON stdout is unchanged.update-settings. Both flags now default to 0, so--helpno longer shows a misleading "(default 1)".Tests:
TestKeyspace_CreateCmdpasses--max-rollout 8, asserts it on the request, and asserts no warning when the response carries it;TestKeyspace_CreateCmdOnlyClusterSizeasserts it is nil when omitted.TestKeyspace_CreateCmdRejectsOutOfRangeMaxRollout(0 and 33 rejected; no API call).TestKeyspace_CreateCmdWarnsWhenMaxRolloutNotApplied: the response lacks the value, so stderr has the warning.TestKeyspaces_Createasserts the exact request body, so the field is not serialized when unset.make testandmake lintpass. Live-tested on a dev cluster on 2026-11-19: create with--max-rollout, the not-applied warning when the server ignores it,update-settings, and local rejection of 0 and 33.