Repository navigation
fix(deps): update dependency simple-git to v4 - #115
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.0.0→^4.0.0Release Notes
steveukx/git-js (simple-git)
v4.1.0Compare Source
Minor Changes
df13aeb: Add theallowConfigandstrictoptions. Configuration keys outside the built-in list of known-safe keys(
SAFE_CONFIG_KEYS) and the keys named inallowConfignow emit a one-offSIMPLE_GIT_UNLISTED_CONFIGwarning,or are rejected when
strict: trueis set. Known-unsafe keys can now be permitted individually throughallowConfig, and environment variables throughallowEnvironment, deprecating theunsafe.allowUnsafe*optionsthat only covered configuration keys or environment variables (they continue to work as before).
4137780: The custom binary (the first string of thebinaryoption orgit.customBinary()) may now contain spaceswhen it looks like a path to a file, for example
C:\Program Files\Git\bin\git.exe. The value must includea path separator and no part of the path may start or end with a space. The prefix (the optional second string)
remains limited to the existing restricted character set, as it is passed to the binary as its first argument.
df13aeb: Addgit.cmdfor running commands written as tagged template literals, where every interpolated value istreated as untrusted data that can't add options, set configuration keys or select a remote helper transport.
Add the
remoteUrl()andrefName()value wrappers for stricter validation of interpolated values.a996f0f: Thanks to @manus-pi and @eliteaja11-dev for submitting CVE proposals that contributed to these changes.When the recommended checks are enabled (with
unsafe.recommended: trueorstrict: true),HOMEandXDG_CONFIG_HOMEsupplied through
.env()with a value other than the one inprocess.envrequireallowUnsafeConfigPaths(or naming them in
allowEnvironment), asgitreads the global configuration from$HOME/.gitconfigand$XDG_CONFIG_HOME/git/configin the same way asGIT_CONFIG_GLOBAL. Passing the inherited value through is unaffected,and neither is removed from the inherited environment.
parseEnvaccepts the inherited environment as an optional second argument, used to compareHOMEandXDG_CONFIG_HOMEagainst.isGuardedEnvKeyis now exported from@simple-git/argv-parser, identifying the environment variables(
GIT_*and the othersgitreads, such asEDITORandPAGER) thatsimple-gitremoves from an inheritedenvironment.
86fadaa: Settle on the use ofstrictto refer to thesimpleGitconfiguration setting to enable strict controls,applying to both Git impacting environment variables and writing to the Git config.
Use of the
strictmode also implies the use ofunsafe.recommendedc8ee6bb: Vulnerability reports:With thanks to @manus-pi, @manus-use, @ba-am, @mspiq, @hoseinenddev, @freyesperales, @dalberrt,
@zer0d4y5, @gamster01, @humaneBicycle, @Hama1cco, @eliteaja11-dev, @Cone-Tester, @Figo5, @MalwareEZ,
@zachariah-mithani, @shaswata56, @Akokonunes for submitting CVE proposals that contributed to these changes.
.cmdorcommandunder the catch-allallowUnsafeCommandBinariessetting (only enforced with the newunsafe.recommendedoption, orstrict), and blockinggpg.ssh.defaultKeyCommandunderallowUnsafeGpgProgram.allowUnsafePagerwill now catch setting a custom binary ingit grep --open-files-in-pager.allowUnsafePagernow also coversinteractive.diffFilter, the shell command thatgit add -pand the other--patchcommands pipe their diff through.allowConfig)allowUnsafeSendEmailConfigoption covering thesendemail.*keys thatgit send-emailruns as commands, reads as files or uses to turn off certificate verification (sendmailCmd,toCmd,ccCmd,headerCmd,smtpServer,smtpServerOption,smtpSSLCertPath,smtpSSLClientCert,smtpSSLClientKey,aliasesFileandmailmap.file, including their per-identitysendemail.<identity>.*variants), and theimap.tunnel,imap.hostandimap.sslVerifykeys used bygit imap-send.allowConfig)allowUnsafeWebServerConfigoption covering theinstaweb.httpd,instaweb.modulePathandinstaweb.gitwebDirkeys used bygit instaweb.allowConfig)allowUnsafeBrowseroption covering thebrowser.<tool>.path,browser.<tool>.cmd,man.<tool>.pathandman.<tool>.cmdkeys used bygit helpandgit instawebto open a browser or man page viewer.browser.<tool>.cmdandman.<tool>.cmdwere previously covered byallowUnsafeCommandBinaries.allowConfig)allowUnsafeSignatureTrustoption coveringgpg.ssh.allowedSignersFile,gpg.ssh.revocationFileandgpg.minTrustLevel, which decide which signatures pass verification.allowUnsafePacknow blocks--execfor every command other thanrebase, as it names the remote program forpush,send-pack,fetch-pack,archive --remoteandls-remote(previously onlypush).allowUnsafeConfigRenameoption blockinggit config --rename-section/git config rename-section, which could move keys written under a harmless section name (eg:foo.fsmonitor) into one that runs commands (core.fsmonitor).allowUnsafeExecnow also covers thegit filter-branchoptions that run a shell command:--setup,--env-filter,--tree-filter,--index-filter,--parent-filter,--msg-filter,--commit-filterand--tag-name-filter.allowUnsafeDiffExternalnow also coversdifftool.<tool>.path, matchingmergetool.<tool>.pathunderallowUnsafeMergeDriver.ddb5b6b: Add theunsafe.recommendedoption, enabling the checks that use broader catch-all rules (such as any configurationkey ending in
.cmdorcommandunderallowUnsafeCommandBinaries). Defaults tofalse, and is implied bystrict: true. It will default totruein the next major version.Each
Vulnerabilityreported by@simple-git/argv-parsernow carries alevelofdefaultfor explicitlyidentified risks, or
recommendedfor those caught by a catch-all rule. TheVulnerabilityLeveltype is exported.Patch Changes
df13aeb: Add a security policy describing which inputs are safe for untrusted data.df13aeb]a996f0f]df13aeb]c8ee6bb]df13aeb]ddb5b6b]v4.0.2Compare Source
Patch Changes
68874c2: AddVISUALenvironment variable to set ofallowUnsafeEditorenvironment variables.Thanks to @oss-security-shopify for identifying the vulnerability.
Updated dependencies [
68874c2]v4.0.1Compare Source
Patch Changes
365f52d: Prepare package.json before publishing.v4.0.0Compare Source
Major Changes
98864c6: Major upgrade to v4. In this version:simpleGitexport.simple-git/promise(change to using the mainsimple-gitimport).gitPexport (change to using the mainsimpleGitexport).gitoptions:Thanks to @anir0y, @CFionaBF, @Leeziao, @internetteletubbie, @idisdi, @the-vibe-dev,
@D7EAD, @dellalibera, @gdegrange, @bilguunbicktivism, @cruzryan, @b1ue0ceanRun, @oss-security-shopify
for identifying the vulnerability.
gitchild process.simpleGit.silent()logging is configured through environment variables in thedebugpackagesimpleGit.clearQueue()this has been a noop since v3, switch to using theabortpluginGitResponseErrorthrough a trailing callback function are available only through theerror.gitproperty (previously properties were also spread onto theerroritself with a deprecation notice).Minor Changes
98864c6: Support one-shot stdin viagit.input(data)(stringorBuffer).Thanks to @felipecrs for the feature request and initial implementation.
Patch Changes
d762810: AddallowUnsafeExecdetection torebase -xandrebase --exec.Thanks to @gdegrange for the vulnerability report.
76f308e: Parse binary rename entries without byte counts in diff summaries.Updated dependencies [
c427fba]Updated dependencies [
1bb14df]Updated dependencies [
dfeb116]Updated dependencies [
d762810]Updated dependencies [
d762810]Updated dependencies [
98864c6]Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.