Add NoopSuggester for disabling Elasticsearch autocomplete#2328
Draft
Add NoopSuggester for disabling Elasticsearch autocomplete#2328
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add NoopSuggester for disabling Elasticsearch autocomplete
Some test environments don’t require Elasticsearch and may prefer to avoid the additional resource overhead it introduces. In addition, certain open-source users are more sensitive to Elasticsearch security advisories. Because we cannot upgrade our bundled Elasticsearch due to licensing restrictions, this change provides an option for disabling Elasticsearch entirely for those who prefer not to run it.
Relevant Issues: N/A
Type of change: /kind feature
Test Plan: Ran cloud with both options and verified that it work
Changelog Message: Add ability to disable Elasticsearch usage in Pixie cloud via
disable_autocompleteapi service flag