CICDL-347: enable public npm publishing via trusted publishers#13
Merged
Merged
Conversation
Switches from token-based npm auth to OIDC trusted publishers, adds publish workflow, and registers repo as a library for org ruleset. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Enables public npm publishing for create-pipedrive-app using npm Trusted Publishers (OIDC-based publishing) and aligns CI to use the repo’s Node version configuration.
Changes:
- Adds an npm publish workflow (
publish.yml) that calls the org reusable npm publish workflow withuse_trusted_publisher: true. - Sets
publishConfig.access: "public"inpackage.jsonfor public registry publishing. - Adds
repository.jsonmetadata and updates CI to use.nvmrcfor Node version selection (and bumps action versions).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
repository.json |
Adds repository metadata (type: "library") for org ruleset coverage. |
package.json |
Adds publishConfig.access = "public" to support public npm publishing behavior. |
.github/workflows/publish.yml |
Introduces a PR-label-triggered publish workflow using Trusted Publishers (OIDC). |
.github/workflows/ci.yml |
Updates CI actions and switches Node version selection to .nvmrc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+8
| types: [labeled] | ||
| branches: [master] | ||
| jobs: | ||
| npm-publish: | ||
| if: contains(github.event.label.name, 'npm-version') |
Comment on lines
+15
to
+16
| contents: read | ||
| secrets: inherit No newline at end of file |
Comment on lines
+13
to
+14
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-node@v6 |
…h label Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d revision input Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…up which has its own tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/publish.yml— caller workflow usingreusable_cicd-npm-publish.ymlwithuse_trusted_publisher: true(OIDC, no NPM token)publishConfig.access: "public"topackage.jsonrepository.jsonwithtype: "library"for org ruleset coverageci.yml: bump actions to v6, use.nvmrcfor Node versionPrerequisites completed (outside this PR)
create-pipedrive-app@0.0.1published on npmjs to claim namepipedrive-incorgpublish.yml)npm-version:patch/minor/majorlabels created on repoTest plan
npm-version:patchlabelnpm view create-pipedrive-appshows the new versionnpx create-pipedrive-app --helpworks from the public registry🤖 Generated with Claude Code