docs: Added Control Plane architecture diagram in Concepts page #7043
docs: Added Control Plane architecture diagram in Concepts page #7043nthapa000 wants to merge 4 commits into
Conversation
…s page Signed-off-by: nthapa000 <nishantthapa0000@gmail.com>
|
👋 Hi @nthapa000, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
|
I have currently added the Control Plane Architecture diagram to the v1.0.x documentation also. However, I'm a little doubtful about whether I should keep it, since there's already a link that redirects users to the Control Plane Architecture Overview. |
Ayushmore1214
left a comment
There was a problem hiding this comment.
Looks like an good approach to me! @rahulshendre thoughts ?
…gram-to-concept-page
|
@nthapa000, you were definitely attentive during the newcomers meet 🙌 |
rahulshendre
left a comment
There was a problem hiding this comment.
Overall LGTM, just copy it to docs dev as well
docs-dev is the working copy that becomes the next v0 release, or it'll be lost on the next v0 release
It doesn't overlap with the link, the diagram gives a quick visual on the concepts page, while the linked page goes deeper with the per-component breakdown, so they serve different purposes and the link is relevant.
I also pulled it locally and it renders cleanly on both v0.57.x and v1.0.x
…ture-diagram-to-concept-page
Signed-off-by: nthapa000 <nishantthapa0000@gmail.com>
Thanks @rahulshendre for feedback, added in docs-dev |
rahulshendre
left a comment
There was a problem hiding this comment.
LGTM 👍🏻
Thanks @nthapa000
What this PR does:
Adds Control Plane architecture diagram in Concepts page
Why we need it:
For better Control Plane architecture overview in v0.57.x
Which issue(s) this PR fixes:
Fixes #7042
v0.57.x

v1.0.x

Does this PR introduce a user-facing change?: