Add CronJob support to FindReferencingConfigMaps and FindReferencingS…#7030
Open
Ankitdotraider wants to merge 1 commit into
Open
Add CronJob support to FindReferencingConfigMaps and FindReferencingS…#7030Ankitdotraider wants to merge 1 commit into
Ankitdotraider wants to merge 1 commit into
Conversation
…ecrets Signed-off-by: Ankit Ram <ankiittt15@gmail.com>
Contributor
|
👋 Hi @Ankitdotraider, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
FindReferencingConfigMaps and FindReferencingSecrets only walk spec.template.spec., which works for Deployment, StatefulSet, and DaemonSet. CronJob nests its pod template under spec.jobTemplate.spec.template.spec., so ConfigMap/Secret references inside a CronJob were silently missed.
Added the missing jobTemplate probes to both functions, in both the kubernetes and kubernetes_multicluster provider packages, following the same pattern already used for the existing paths. Added test cases covering CronJob ConfigMap/Secret references in both packages.
Scoped to just these two functions no changes to FindContainerImages or anything else, to keep this focused.
Why we need it:
Without this fix, PipeCD's drift detection and re-deploy triggering silently ignore config/secret changes in CronJob workloads.
Which issue(s) this PR fixes:
Fixes #6761
Does this PR introduce a user-facing change?: