Improve website accessibility to address Lighthouse audit findings from #7019#7029
Open
Shanwis wants to merge 1 commit into
Open
Improve website accessibility to address Lighthouse audit findings from #7019#7029Shanwis wants to merge 1 commit into
Shanwis wants to merge 1 commit into
Conversation
Shanwis
requested review from
Warashi,
khanhtc1202,
mohammedfirdouss and
t-kikuc
July 14, 2026 08:30
Contributor
|
👋 Hi @Shanwis, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
pipe-cd#7019 Signed-off-by: Shanwis <ashsanthosh8@gmail.com>
Shanwis
force-pushed
the
improve-accessibility-lighthouse
branch
from
July 14, 2026 08:32
c220247 to
73bcb18
Compare
|
@Shanwis looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR addresses a focused subset of the Lighthouse accessibility recommendations from Issue #7019, improving the website's accessibility score from 81 to 100 without changing its appearance or functionality.
Direct Lighthouse Failure Fixes
General Improvements (not in Lighthouse failures)
<nav>element<div>→<footer>(semantic HTML)<div>→<p>(semantic HTML)<div class="value-title h2">→<h2 class="value-title">(proper heading hierarchy)<p class="value-body">→<div class="value-body">(fixes invalid<ul>inside<p>)Why we need it:
A Lighthouse audit identified several opportunities to improve the website's accessibility. This PR addresses the remaining automated accessibility failures (after #7020's SEO changes) by:
<h2>,<p>,<footer>,<nav>) for proper document structure and landmark navigationWhich issue(s) this PR fixes:
Fixes #7019
Does this PR introduce a user-facing change?:
Yes.