fix(piped): clean up cloned repo after skip stage check#7021
Open
Ahmad-Faraj wants to merge 1 commit into
Open
fix(piped): clean up cloned repo after skip stage check#7021Ahmad-Faraj wants to merge 1 commit into
Ahmad-Faraj wants to merge 1 commit into
Conversation
Signed-off-by: Ahmad Faraj <ahmedfrag4040@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a resource leak in the legacy piped controller by ensuring the temporary git worktree created during shouldSkipStage is cleaned up after each skip check, preventing accumulation of leftover clone directories over time.
Changes:
- Add a deferred cleanup (
repo.Clean()) after successfully cloning the repository inshouldSkipStage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
shouldSkipStageclones the repo into a temporary directory on every skip check but never removes it. Each check with skipOn conditions leaks one temp directory until the piped restarts. This adds a deferredrepo.Clean(), the same pattern the drift detectors and the event watcher use.Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: