Skip OCI registry tests when Docker is unavailable#7009
Open
rootp1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: rootp1 <arnav.iitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/ocitests cleanly when the Docker daemon is unavailable instead of aborting the whole package inTestMainLinked Issue
Fixes #7008
What Changed
requireOCIRegistryhelperVerification
go test ./pkg/oci— passedgo test -v ./pkg/oci— passedgo test ./pkg/... ./cmd/...— failed: unrelated envtest prerequisite missing (/usr/local/kubebuilder/bin/etcdnot found inpkg/app/piped/executor/kubernetes)make check— failed:yarnis not installed, so the required web build step could not runmake lint/go MODULES=.— failed:dockeris not installed, so the lint container could not startmake check/dco— failed: the script checks commits sinceorigin/masterand stops on upstream commit25ae69937e55e8330bff96c34346718f3e5e7148, which already lacks a sign-off in this local rangegit diff --check— passedScope
pkg/ocitest files were changed; unrelated tracked files were not modifiedWhat this PR does:
Skips Docker-dependent OCI registry tests cleanly when Docker is unavailable and keeps genuine setup failures visible.
Why we need it:
Plain Go test runs should not abort on machines that do not have a Docker daemon available.
Which issue(s) this PR fixes:
Fixes #7008
Does this PR introduce a user-facing change?:
pkg/ocisolely because Docker is unavailable