cc: trim OnTransportCCFeedback result to PacketStatusCount#414
Open
AnshulMalik wants to merge 1 commit intopion:mainfrom
Open
cc: trim OnTransportCCFeedback result to PacketStatusCount#414AnshulMalik wants to merge 1 commit intopion:mainfrom
AnshulMalik wants to merge 1 commit intopion:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 80.07% 80.12% +0.05%
==========================================
Files 88 88
Lines 4602 4604 +2
==========================================
+ Hits 3685 3689 +4
+ Misses 734 733 -1
+ Partials 183 182 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StatusVectorChunks always encode a fixed number of slots (7 for 2-bit symbols, 14 for 1-bit). When the reported packet count does not fill the final chunk, the encoder pads the remaining slots with TypeTCCPacketNotReceived. Without trimming, those padding slots are looked up in the send history and, if found, returned as Acknowledgments with zero Arrival time. The loss estimator then counts them as lost packets, inflating the loss estimate even though those packets are still in flight. Fix by truncating the result to PacketStatusCount after processing all chunks, which is the authoritative count of packets the feedback actually covers.
AnshulMalik
force-pushed
the
fix-status-vector-chunk-padding
branch
from
c557388 to
97268a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusVectorChunks always encode a fixed number of slots (7 for 2-bit symbols, 14 for 1-bit). When the number of reported packets does not fill the final chunk, the encoder pads the remaining slots with TypeTCCPacketNotReceived symbols.
Without trimming, those padding slots are looked up in the send history and, if found (e.g. recently sent packets whose SNs happen to fall in the padding range), are returned as Acknowledgments with a zero Arrival time. The loss estimator then counts them as lost packets, inflating the loss estimate even though those packets are still in flight.