Fix Android adaptive launcher icon#4332
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Consolidates Android adaptive launcher icon foreground to a single asset across all build variants. The change is purely cosmetic (app icon appearance) with no runtime logic impact, plus documentation updates. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 0b746f1
513a946 to
7b1aca5
Compare
7b1aca5 to
b5839de
Compare
What Changed
Why
The previous foreground already contained a rounded-square icon silhouette. Android then masked that composed image again, producing a cramped, double-framed launcher icon.
UI Changes
Android 15 / API 35 Google APIs x86_64 image in Pixel Launcher. Left: previous development icon. Right: revised flat adaptive foreground.
The production x86_64 release APK was also installed and launched on the emulator; it reached the normal No environments connected screen without an Android runtime crash.
Checklist
vp check(0 errors; 14 pre-existing warnings outside this diff)vp run lint:mobile(passes; optional SwiftLint/ktlint/detekt unavailable on this Linux host)apps/mobile/app.config.tsand the new assetslibrsvgvp run typecheckis blocked outside this diff: marketing prompts for@astrojs/check, while unchanged oxlint/mobile tests fail against the installed@effect/vitestexportsNote
Low Risk
Branding and Expo asset path changes only; no auth, data, or application logic.
Overview
Fixes the double-framed Android launcher icon by pointing development, preview, and production at one shared adaptive foreground (
./assets/android-icon-foreground.png) instead of variant-specific universal exports that already included a rounded-square silhouette.Adds
android-icon-foreground.svgas the source of truth (flat white T3 mark on a transparent canvas, sized for the adaptive safe zone) and documents regenerating the paired PNG withrsvg-convertinassets/README.md. Per-variant adaptive background colors andandroid-icon-mark.pngfor monochrome themed icons are unchanged.Reviewed by Cursor Bugbot for commit b5839de. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix Android adaptive launcher icon across all build variants
Replaces per-variant adaptive foreground icon paths with a single shared asset at
./assets/android-icon-foreground.png. Adds the new PNG and SVG source files, and documents how to re-export the PNG usingrsvg-convertat 432×432. The existingandroid-icon-mark.pngis kept for monochrome themed icons.Macroscope summarized b5839de.