Skip to content

Fix Android adaptive launcher icon#4332

Open
colonelpanic8 wants to merge 2 commits into
pingdotgg:mainfrom
colonelpanic8:fix/android-adaptive-icon
Open

Fix Android adaptive launcher icon#4332
colonelpanic8 wants to merge 2 commits into
pingdotgg:mainfrom
colonelpanic8:fix/android-adaptive-icon

Conversation

@colonelpanic8

@colonelpanic8 colonelpanic8 commented Jul 23, 2026

Copy link
Copy Markdown

What Changed

  • replace composed universal Android app icons with a transparent, adaptive-only T3 foreground
  • use a smaller, flat white mark with corrected optical centering and safe-zone spacing
  • preserve each Android variant's background color and the monochrome themed icon
  • keep an SVG source of truth and document deterministic PNG regeneration

Why

The previous foreground already contained a rounded-square icon silhouette. Android then masked that composed image again, producing a cramped, double-framed launcher icon.

UI Changes

Android 15 / API 35 Google APIs x86_64 image in Pixel Launcher. Left: previous development icon. Right: revised flat adaptive foreground.

Before on the left and after on the right

The production x86_64 release APK was also installed and launched on the emulator; it reached the normal No environments connected screen without an Android runtime crash.

Checklist

  • vp check (0 errors; 14 pre-existing warnings outside this diff)
  • vp run lint:mobile (passes; optional SwiftLint/ktlint/detekt unavailable on this Linux host)
  • focused formatting/lint checks for apps/mobile/app.config.ts and the new assets
  • byte-for-byte SVG-to-PNG regeneration with librsvg
  • Expo config inspected for development, preview, and production variants
  • production release APK built, installed, and launched on an API 35 emulator
  • vp run typecheck is blocked outside this diff: marketing prompts for @astrojs/check, while unchanged oxlint/mobile tests fail against the installed @effect/vitest exports

Note

Low Risk
Branding and Expo asset path changes only; no auth, data, or application logic.

Overview
Fixes the double-framed Android launcher icon by pointing development, preview, and production at one shared adaptive foreground (./assets/android-icon-foreground.png) instead of variant-specific universal exports that already included a rounded-square silhouette.

Adds android-icon-foreground.svg as the source of truth (flat white T3 mark on a transparent canvas, sized for the adaptive safe zone) and documents regenerating the paired PNG with rsvg-convert in assets/README.md. Per-variant adaptive background colors and android-icon-mark.png for monochrome themed icons are unchanged.

Reviewed by Cursor Bugbot for commit b5839de. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Android adaptive launcher icon across all build variants

Replaces per-variant adaptive foreground icon paths with a single shared asset at ./assets/android-icon-foreground.png. Adds the new PNG and SVG source files, and documents how to re-export the PNG using rsvg-convert at 432×432. The existing android-icon-mark.png is kept for monochrome themed icons.

Macroscope summarized b5839de.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd2de03c-05b3-409c-9043-e761e3a63bd6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 23, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 23, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Consolidates Android adaptive launcher icon foreground to a single asset across all build variants. The change is purely cosmetic (app icon appearance) with no runtime logic impact, plus documentation updates.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review July 23, 2026 06:01

Dismissing prior approval to re-evaluate 0b746f1

@colonelpanic8
colonelpanic8 force-pushed the fix/android-adaptive-icon branch 9 times, most recently from 513a946 to 7b1aca5 Compare July 24, 2026 01:41
@colonelpanic8
colonelpanic8 force-pushed the fix/android-adaptive-icon branch from 7b1aca5 to b5839de Compare July 24, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant