Skip to content

[codex] Group projects in new-thread pickers#4312

Open
juliusmarminge wants to merge 3 commits into
codex/sidebar-v2-grouped-filterfrom
codex/grouped-project-pickers
Open

[codex] Group projects in new-thread pickers#4312
juliusmarminge wants to merge 3 commits into
codex/sidebar-v2-grouped-filterfrom
codex/grouped-project-pickers

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 22, 2026

Copy link
Copy Markdown
Member

Why

After Sidebar V2 groups duplicate repository copies, its new-thread flows can still list every physical environment/project pair. That makes the picker disagree with the sidebar and presents redundant choices.

Root cause

The command palette and global new-thread route consume the raw project collection rather than logical project snapshots.

Fix

  • present one entry per logical project in the command palette
  • prefer the active concrete project as the creation target
  • make the global shortcut use logical project count

Dependency

Stacked on PR #4282 because it reuses the logical grouping helpers introduced there.

Verification

  • targeted formatting and lint
  • vp run --filter @t3tools/web typecheck

Note

Group projects by logical groups in new-thread pickers and command palette

  • Project items in the command palette are now titled by group display names rather than raw project names; search terms include all member project titles and workspace roots.
  • Opening a project from search jumps to the latest non-archived thread across all projects in the group, rather than a single project.
  • Creating a new thread from the command palette targets the contextual project ref when it belongs to the selected group.
  • The chat.new shortcut now opens the command palette only when there is more than one logical project group, not merely more than one raw project.

Macroscope summarized f6f19ce.


Note

Low Risk
UI-only routing and picker aggregation in the web app; reuses existing sidebar grouping helpers with no auth or data-layer changes.

Overview
Aligns command palette and global chat.new behavior with Sidebar V2 logical project groups so pickers no longer list every physical environment/project copy.

The palette builds one row per logical group (buildSidebarProjectSnapshots / buildSidebarProjectPickerEntries), uses each group’s display name, and extends buildProjectActionItems with optional extra search terms from all member projects. Opening a grouped project navigates to the latest non-archived thread across the whole group (not just the target project). New thread in… keeps the user’s contextual project ref when it belongs to the selected group.

The root “New thread in …” label prefers the preferred picker group name. chat.new in _chat.tsx opens the palette only when projectGroupCount > 1 (logical groups), not raw project count.

Reviewed by Cursor Bugbot for commit f6f19ce. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f3740c70-e033-4640-bf65-e1e7e0d42d1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/grouped-project-pickers

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 22, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review July 22, 2026 22:35
Comment thread apps/web/src/components/CommandPalette.tsx Outdated
Comment thread apps/web/src/components/CommandPalette.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature that groups projects in command palette pickers, changing how users see and search for projects. The logic for finding latest threads and building search terms is modified to work across grouped projects. New user-facing behavior warrants human review.

You can customize Macroscope's approvability policy. Learn more.

juliusmarminge and others added 2 commits July 23, 2026 01:14
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the codex/grouped-project-pickers branch from e7d474e to 7ec6918 Compare July 22, 2026 23:14

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 7ec6918. Configure here.

Comment thread apps/web/src/components/CommandPalette.tsx
Comment thread apps/web/src/components/CommandPalette.tsx Outdated
Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant