Skip to content

Add search to new-thread project picker#4259

Open
colonelpanic8 wants to merge 9 commits into
pingdotgg:mainfrom
colonelpanic8:t3code/searchable-new-thread-projects
Open

Add search to new-thread project picker#4259
colonelpanic8 wants to merge 9 commits into
pingdotgg:mainfrom
colonelpanic8:t3code/searchable-new-thread-projects

Conversation

@colonelpanic8

@colonelpanic8 colonelpanic8 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • replace the new-thread project menu with a searchable picker
  • narrow candidates incrementally by project name or workspace path as the user types
  • auto-highlight the first remaining candidate so Enter selects it
  • preserve the existing New project action

Verification

  • vp test run src/components/chat/draftHeroProjectSearch.test.ts --project unit
  • vp lint and vp fmt on the changed files
  • pnpm run typecheck in apps/web

Isolated exact-head browser verification of incremental search completed against disposable projects; the server and test data were stopped and removed afterward.

Exact-head evidence

Revalidated at 064fa4b on current main (9a0a071): focused tests, vp check, and vp run typecheck passed. The capture uses only disposable local projects.

Searchable new-thread project picker filtered to Cedar Docs


Note

Low Risk
UI-only change to draft hero project selection with tested helpers; no auth, data, or API impact.

Overview
Replaces the draft-hero project menu with a searchable Combobox so users can filter projects by title and workspace path (multi-token matching) while keeping sidebar sort order.

Filtering and picker behavior live in new draftHeroProjectSearch helpers: prefixed item values keep projects distinct from the New project action, filteredItems always include that footer action, and autoHighlight supports Enter on the first match. Keyboard handling blocks accidental Enter on New project after a failed search until arrow navigation, and preserves IME composition on Enter.

Unit tests cover filtering, item lists, and key-resolution edge cases.

Reviewed by Cursor Bugbot for commit b872596. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add search to the new-thread project picker

  • Replaces the menu-based project selector in DraftHeroHeadline with a searchable Combobox that filters projects by title and workspace path using multi-token matching.
  • A "New project" action item is always appended at the end of the picker list; selecting it opens the add-project command palette.
  • Keyboard handling in draftHeroProjectSearch.ts preserves IME Enter composition and requires explicit arrow-key navigation before Enter can select the "New project" footer action after a failed search.

Macroscope summarized b872596.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ac0ee92d-ab94-4881-850e-d80b0c428b50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 22, 2026
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Self-contained UI enhancement adding search to the project picker dropdown. Changes are localized to one component with pure filtering logic and unit tests. No backend, API, or schema impact.

You can customize Macroscope's approvability policy. Learn more.

Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 10:36

Dismissing prior approval to re-evaluate 14cbec2

Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch from 32a2bd7 to 12a2d75 Compare July 22, 2026 12:07
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 12:20

Dismissing prior approval to re-evaluate af5decc

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

BEFORE/AFTER SCREENSHOTS FOR UI CHANGES
CleanShot 2026-07-22 at 14 32 06@2x

1 similar comment
@juliusmarminge

Copy link
Copy Markdown
Member

BEFORE/AFTER SCREENSHOTS FOR UI CHANGES
CleanShot 2026-07-22 at 14 32 06@2x

@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch 2 times, most recently from 19c6cae to a8bcd66 Compare July 22, 2026 15:43
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 15:53

Dismissing prior approval to re-evaluate e3fbb39

Comment thread apps/web/src/components/chat/draftHeroProjectSearch.ts
Comment thread apps/web/src/components/chat/DraftHeroHeadline.tsx
@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch 2 times, most recently from 57871a2 to 3d3310b Compare July 22, 2026 16:22

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3d3310b. Configure here.

Comment thread apps/web/src/components/chat/draftHeroProjectSearch.ts Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 16:37

Dismissing prior approval to re-evaluate 064fa4b

@colonelpanic8
colonelpanic8 force-pushed the t3code/searchable-new-thread-projects branch from 064fa4b to b872596 Compare July 22, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants