Add search to new-thread project picker#4259
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Self-contained UI enhancement adding search to the project picker dropdown. Changes are localized to one component with pure filtering logic and unit tests. No backend, API, or schema impact. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 14cbec2
32a2bd7 to
12a2d75
Compare
Dismissing prior approval to re-evaluate af5decc
1 similar comment
19c6cae to
a8bcd66
Compare
Dismissing prior approval to re-evaluate e3fbb39
57871a2 to
3d3310b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d3310b. Configure here.
Dismissing prior approval to re-evaluate 064fa4b
064fa4b to
b872596
Compare


Summary
Verification
vp test run src/components/chat/draftHeroProjectSearch.test.ts --project unitvp lintandvp fmton the changed filespnpm run typecheckinapps/webIsolated exact-head browser verification of incremental search completed against disposable projects; the server and test data were stopped and removed afterward.
Exact-head evidence
Revalidated at 064fa4b on current main (9a0a071): focused tests, vp check, and vp run typecheck passed. The capture uses only disposable local projects.
Note
Low Risk
UI-only change to draft hero project selection with tested helpers; no auth, data, or API impact.
Overview
Replaces the draft-hero project menu with a searchable Combobox so users can filter projects by title and workspace path (multi-token matching) while keeping sidebar sort order.
Filtering and picker behavior live in new
draftHeroProjectSearchhelpers: prefixed item values keep projects distinct from the New project action,filteredItemsalways include that footer action, andautoHighlightsupports Enter on the first match. Keyboard handling blocks accidental Enter on New project after a failed search until arrow navigation, and preserves IME composition on Enter.Unit tests cover filtering, item lists, and key-resolution edge cases.
Reviewed by Cursor Bugbot for commit b872596. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add search to the new-thread project picker
DraftHeroHeadlinewith a searchable Combobox that filters projects by title and workspace path using multi-token matching.draftHeroProjectSearch.tspreserves IME Enter composition and requires explicit arrow-key navigation before Enter can select the "New project" footer action after a failed search.Macroscope summarized b872596.