docs: Refactor AGENTS.md to clarify provider architecture and Claude implementation#1566
Open
Ivorisnoob wants to merge 1 commit intopingdotgg:mainfrom
Open
docs: Refactor AGENTS.md to clarify provider architecture and Claude implementation#1566Ivorisnoob wants to merge 1 commit intopingdotgg:mainfrom
Ivorisnoob wants to merge 1 commit intopingdotgg:mainfrom
Conversation
- Update server package description to mention Claude Agent SDK alongside Codex - Add desktop package role description for Electron shell and t3 backend - Restructure provider documentation with dedicated sections for Codex and Claude - Document low-level and high-level layers for Codex provider integration - Add Claude provider implementation details and adapter location - Explain unified provider workflow from WebSocket requests through event projection - Clarify how adapters delegate to respective agent runtimes and emit canonical events - Improve clarity on provider architecture for future maintainability
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
AGENTS.mdto accurately reflect that both Codex and Claude providers are fully implementedapps/desktoppackage role description for Electron shell and t3 backendcodexAppServerManager.ts) and high-level (CodexAdapter.ts) layers for Codexbun testinstead of incorrect "NEVER runbun test")providerManager.tsWhy
The previous documentation was misleading:
This refactoring improves clarity for maintainers and contributors about how providers work in the codebase.
Checklist
Note
Low Risk
Documentation-only updates that don’t change runtime behavior; risk is limited to potential confusion if descriptions drift from implementation.
Overview
Refactors
AGENTS.mdto describe the multi-provider architecture (Codex and Claude) with clearer layering (manager vs adapter) and the end-to-end request/event flow fromwsServer.tsthroughProviderService, reactors, andServerPushBus.Updates package role descriptions (including
apps/desktop) and removes/avoids outdated references (e.g.,providerManager.ts).Written by Cursor Bugbot for commit 9d88de8. This will update automatically on new commits. Configure here.
Note
Refactor AGENTS.md to document provider architecture and Claude implementation
Updates AGENTS.md to replace the narrow 'Codex App Server' section with a broader 'Provider Architecture' section covering both providers.
provider: "codex") with its low-level manager and high-level adapter, and the Claude provider (provider: "claudeAgent") as an adapter over the Claude Agent SDK, both managed byProviderService.ProviderService, adapter delegation, event emission, ingestion/reactors pipeline, persistence/projection, andServerPushBusupdates.apps/desktoppackage entry describing the Electron shell and desktop-scoped backend process.Macroscope summarized 9d88de8.