Fix Claude [ede_diagnostic] red popups#1554
Open
Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a265f86 to
e946446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Claude: Mark results that have 'is_error === false' as completed, plus specifically filter for [ede_diagnostic]
Why
Claude SDK sometimes does give "diagnostics" which aren't actually errors, so shouldn't trigger a red pop up in UI
Checklist
Note
Low Risk
Low risk: small, localized change to Claude result classification and error-message selection that mainly affects UI error surfacing and turn status reporting.
Overview
Prevents Claude SDK diagnostic messages from surfacing as user-facing failures.
turnStatusFromResultnow treats result messages withis_error === falseascompleted(after existing interrupted/cancelled checks), andhandleResultMessagenow filters out[ede_diagnostic]entries when choosing an error message to emit/record, reducing spurious red error popups.Written by Cursor Bugbot for commit e946446. This will update automatically on new commits. Configure here.
Note
Fix
[ede_diagnostic]errors appearing as red popups in Claude turns[ede_diagnostic]error entries when selecting the error message for failed Claude turns inhandleResultMessage; if only diagnostics are present, the error message isundefinedand falls back to "Claude turn failed."turnStatusFromResultto return"completed"whenresult.is_error === false, preventing non-error results from falling through to"failed".[ede_diagnostic]errors no longer surface a specific error message to the user.Macroscope summarized e946446.