Skip to content

Fix Claude [ede_diagnostic] red popups#1554

Open
Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Alexx999:pr-fix-ede_diagnostic
Open

Fix Claude [ede_diagnostic] red popups#1554
Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Alexx999:pr-fix-ede_diagnostic

Conversation

@Alexx999
Copy link
Copy Markdown
Contributor

@Alexx999 Alexx999 commented Mar 29, 2026

What Changed

Claude: Mark results that have 'is_error === false' as completed, plus specifically filter for [ede_diagnostic]

Why

Claude SDK sometimes does give "diagnostics" which aren't actually errors, so shouldn't trigger a red pop up in UI

Checklist

  • This PR is small and focused
  • I explained what changed and why

Note

Low Risk
Low risk: small, localized change to Claude result classification and error-message selection that mainly affects UI error surfacing and turn status reporting.

Overview
Prevents Claude SDK diagnostic messages from surfacing as user-facing failures.

turnStatusFromResult now treats result messages with is_error === false as completed (after existing interrupted/cancelled checks), and handleResultMessage now filters out [ede_diagnostic] entries when choosing an error message to emit/record, reducing spurious red error popups.

Written by Cursor Bugbot for commit e946446. This will update automatically on new commits. Configure here.

Note

Fix [ede_diagnostic] errors appearing as red popups in Claude turns

  • Filters out SDK-internal [ede_diagnostic] error entries when selecting the error message for failed Claude turns in handleResultMessage; if only diagnostics are present, the error message is undefined and falls back to "Claude turn failed."
  • Fixes turnStatusFromResult to return "completed" when result.is_error === false, preventing non-error results from falling through to "failed".
  • Behavioral Change: non-success results containing only [ede_diagnostic] errors no longer surface a specific error message to the user.

Macroscope summarized e946446.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4f8d18ed-68e2-479e-9960-03a8793d0b39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 29, 2026
@Alexx999 Alexx999 force-pushed the pr-fix-ede_diagnostic branch from a265f86 to e946446 Compare March 29, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant