fix(web): dismiss mobile sidebar sheet after navigation#1549
Open
henrik092 wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(web): dismiss mobile sidebar sheet after navigation#1549henrik092 wants to merge 1 commit intopingdotgg:mainfrom
henrik092 wants to merge 1 commit intopingdotgg:mainfrom
Conversation
On mobile, the sidebar renders as a slide-over sheet. After tapping a thread, creating a new thread, or navigating to settings, the sheet stays open and must be manually dismissed. Add a closeMobileSidebar() helper that calls setOpenMobile(false) when isMobile is true, and invoke it after: - plain-click thread navigation (handleThreadClick) - programmatic thread navigation (navigateToThread) - new thread creation - settings navigation Fixes pingdotgg#1258
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile, the sidebar renders as a slide-over sheet. After tapping a thread, creating a new thread, or navigating to settings, the sheet stays open and must be manually dismissed.
Add a closeMobileSidebar() helper that calls setOpenMobile(false) when isMobile is true, and invoke it after:
Fixes #1258
What Changed
Why
UI Changes
Checklist
Note
Low Risk
Low risk UI behavior change limited to calling
setOpenMobile(false)after user-initiated navigations; minimal impact outside mobile and no data/auth logic touched.Overview
Ensures the mobile sidebar (sheet) auto-dismisses after navigation actions.
Sidebarnow usesuseSidebar()to add acloseMobileSidebar()helper and calls it after thread navigation (click and keyboard/programmatic), after creating a new thread from a project, and after navigating to Settings.Written by Cursor Bugbot for commit be06b7b. This will update automatically on new commits. Configure here.
Note
Dismiss mobile sidebar sheet after navigation in
SidebarOn mobile, the sidebar sheet previously stayed open after navigating to a thread, creating a new thread, or opening Settings. A
closeMobileSidebarcallback (viauseSidebar) is now called after each navigation action in Sidebar.tsx, so the sheet closes automatically on mobile.Macroscope summarized be06b7b.