-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(claude): emit plan events for TodoWrite during input streaming #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TimCrooker
wants to merge
15
commits into
pingdotgg:main
Choose a base branch
from
TimCrooker:fix/claude-todowrite-plan-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+187
−29
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
84deaea
fix(claude): emit plan events for TodoWrite during input streaming
TimCrooker fe30dce
Persist plan sidebar across turns and simplify isTodoTool
TimCrooker 689906f
Fix task.completed tone and label handling
TimCrooker 25fb9d1
Merge branch 'main' into fix/claude-todowrite-plan-events
TimCrooker a7a82be
Fix sidebar dismiss when plan turnId is null
TimCrooker 5f86883
Fix sidebar X button dismiss for null turnId
TimCrooker 6bd7754
Merge branch 'main' into fix/claude-todowrite-plan-events
TimCrooker 3bc417b
Align dismiss key computation in auto-open effect
TimCrooker 6d703af
Show "Tasks" instead of "Plan" when no plan is active
TimCrooker 7964460
Fix auto-open on thread switch, add parentheses, deduplicate label/de…
TimCrooker 21b1aa4
Add explicit parentheses to planSidebarLabel ternary
TimCrooker b22f5db
Merge branch 'main' into fix/claude-todowrite-plan-events
TimCrooker d374687
Merge branch 'main' into fix/claude-todowrite-plan-events
TimCrooker 8147fcd
Merge remote-tracking branch 'origin/main' into fix/claude-todowrite-…
TimCrooker 80dfdbd
Merge remote-tracking branch 'fork/fix/claude-todowrite-plan-events' …
TimCrooker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macroscopeapp[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty todo content produces invalid plan step string
Low Severity
extractPlanStepsFromTodoInputsetssteptotodo.contentwhen it's a string, but doesn't guard against empty or whitespace-only strings. TheRuntimePlanStepschema requiresstepto be aTrimmedNonEmptyString. If Claude sends a todo withcontent: ""orcontent: " ", the resulting plan step would fail schema validation, potentially disrupting the streaming event pipeline. The fallback"Task"only applies whencontentis not a string at all.