-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Handle missing workspaces across server and UI #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High t3code/apps/server/src/orchestration/Layers/CheckpointReactor.ts Lines 176 to 193 in ae625d2
When const cwd = input.preferSessionRuntime
? (Option.match(fromSession, {
onNone: () => undefined,
onSome: (runtime) => runtime.cwd,
}) ?? fromThread)
: (fromThread ??
Option.match(fromSession, {
onNone: () => undefined,
onSome: (runtime) => runtime.cwd,
}));
- if (input.thread.effectiveCwdState !== "available" || !cwd) {
+ const resolvedState = yield* Effect.promise(() =>
+ inspectWorkspacePathState(cwd ?? input.thread.effectiveCwd ?? ""),
+ );
+ if (resolvedState !== "available" || !cwd) {
return undefined;
}
if (!isGitWorkspace(cwd)) {Also found in 1 other location(s)
🚀 Reply "fix it for me" or copy this AI Prompt for your agent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant workspace assertion in statusDetails before execute
Low Severity
ensureGitWorkspaceinstatusDetailsis redundant because theexecutewrapper (line 618–632) already callsassertWorkspaceDirectoryfor every git command. The three subsequentrunGitStdoutcalls each go throughexecute, so the workspace is validated four times total. TheensureGitWorkspacehelper itself is only used in this one location.