Skip to content

feat(web): add provider model bulk toggle - #10947

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:feat/provider-model-bulk-toggle
Sep 9, 2026
Merged

feat(web): add provider model bulk toggle#10947
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:feat/provider-model-bulk-toggle

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add a provider-level bulk toggle that disables every built-in model, then changes to enable them after they are all hidden.

Why

Managing a provider with many models currently requires toggling each model one at a time.

Evidence

disable-enable-all-models.mov

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for UI changes
  • I included a video for animation/interaction changes

Verification

  • vp test run apps/web/src/components/settings/ProviderModelsSection.test.ts
  • vp run --filter @t3tools/web typecheck

Built with Codex.

Summary by CodeRabbit

  • New Features
    • Added a bulk toggle in provider settings to disable or enable all built-in models.
    • The toggle updates the model visibility list while preserving custom models.

Add a toggle that disables every built-in model for a provider and enables them again once all are hidden.\n\nBuilt with Codex.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 9, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persistent bulk model-visibility capability to the provider settings UI, affecting which built-in models appear in the picker after user interaction. The implementation is small and localized, but the production behavior is new and touches a shared component, so human review is appropriate.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d798bc21-13e8-42ed-83b3-88abbaabdb98

📥 Commits

Reviewing files that changed from the base of the PR and between 6c58362 and 5cc4f10.

📒 Files selected for processing (2)
  • apps/web/src/components/settings/ProviderModelsSection.test.ts
  • apps/web/src/components/settings/ProviderModelsSection.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The provider models section adds a bulk toggle for built-in models. The toggle enables or disables all built-in models while preserving custom models and unrelated hidden entries. Tests cover both operations.

Changes

Provider model bulk toggle

Layer / File(s) Summary
Bulk hidden-model calculation
apps/web/src/components/settings/ProviderModelsSection.tsx, apps/web/src/components/settings/ProviderModelsSection.test.ts
The exported nextHiddenModelsForBulkToggle helper adds all built-in slugs when disabling models and removes them when enabling models. Tests cover both behaviors.
Bulk toggle UI integration
apps/web/src/components/settings/ProviderModelsSection.tsx
The component detects when all built-in models are hidden and renders a Disable all or Enable all button that applies the helper result.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5cc4f

This adds provider-level enable and disable actions for built-in models while preserving custom models and unrelated hidden entries. The behavior is covered by targeted tests and is ready to merge.

Suggested reviewers: stienswout, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: adding a provider model bulk toggle.
Description check ✅ Passed The description explains what changed, why it changed, and how it was verified. It includes an evidence attachment and checklist, but it does not provide a dedicated UI Changes section or clearly iden…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@UtkarshUsername UtkarshUsername changed the title [WIP] feat(web): add provider model bulk toggle feat(web): add provider model bulk toggle Sep 9, 2026
@juliusmarminge
juliusmarminge merged commit e16b8b0 into pingdotgg:main Sep 9, 2026
21 checks passed
@UtkarshUsername
UtkarshUsername deleted the feat/provider-model-bulk-toggle branch September 9, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants