fix(server): distinguish the Antigravity CLI from the missing ACP runtime - #10932
fix(server): distinguish the Antigravity CLI from the missing ACP runtime#10932Marve10s wants to merge 2 commits into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a narrowly scoped server-side diagnostic fix that distinguishes an installed Antigravity CLI from the separate ACP runtime without changing successful resolution or installation paths. A known medium-severity POSIX empty-PATH edge case remains independently blocking under the repository’s correctness policy. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Antigravity installation resolver now uses the shared ChangesAntigravity installation resolution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Antigravity status now distinguishes an installed CLI from a missing ACP agent, giving users the correct installation guidance while preserving existing resolution behavior. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29da082724
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What Changed
When no Antigravity ACP runtime is found, the provider status now checks whether the
agyCLI is onPATH. If it is, the status reads:The existing "Antigravity is not installed" message is unchanged for machines without the CLI. Resolution order, managed installs, PATH lookup of
agy_acp_server.par, and the custom binary path override all behave as before.Why
The Antigravity provider runs Google's
agy_acp_server.parACP agent, not theagyCLI. Anyone who already uses the CLI sees "Antigravity is not installed" next to a tool they installed and use daily, which reads as a detection bug rather than a setup step. The provider has no way to say "you have the wrong binary", so users go looking for a PATH or permissions problem instead of pressing Install in Settings > Providers.The message is the only thing that is wrong here. The alternative would be to accept the CLI as a runtime and drive it directly, which is what #3056 originally asked for. That path is far more complex: the CLI has no ACP mode, print mode cannot surface permission prompts, and events would have to come from undocumented transcript files. #9348 deliberately chose the official ACP agent instead, so this change keeps that design and only makes the status honest about which binary is missing.
Summary by CodeRabbit
Bug Fixes