fix(web): prevent seams in the topbar scroll fade - #10914
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This CSS-only change adjusts the existing topbar fade mask by one pixel in both browser-specific declarations, affecting only a localized visual detail. It is small, self-contained, and does not alter product defaults, interfaces, workflows, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe titlebar scroll-fade masks now extend their configured fade height by 1px for WebKit and standard mask implementations. ChangesTitlebar fade
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The shared topbar scroll fade now overlaps its layers by 1px to eliminate visible seams. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What Changed
Overlap the gradient and solid layers of the topbar scroll mask by 1px, in both
mask-sizeand-webkit-mask-size.Why
Text scrolling under the workspace title bar can acquire a thin dark line where the mask layers meet. At a 17px interface font, the 1.5rem fade is 25.5px high; rasterization can leave a partially transparent row at that fractional boundary. The overlap closes that gap.
The shared utility covers the message timeline, Settings, and pull-request views on web and desktop.
This uses the same approach as the still-open #7787. The screenshots below independently reproduce the issue and verify the fix.
UI Changes
Captured from the actual T3 Code Electron app with an isolated profile and invented workspace, chat, and browser content. Iris dark theme, 17px interface font, 100% zoom, 1440 × 960 window. Each pair changes only this PR's fix.
Full app captures
Before:
After:
Validation
bun fmtbun lintbun typecheck(full workspace)apps/web:bun run test src/components/chat/MessagesTimeline.test.tsx— 46 tests passed.Checklist
No animation or interaction behavior changes; a video is not applicable.
Summary by CodeRabbit