Skip to content

fix(mobile): prevent overlapping Android thread rows #10901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
none23 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

fix(mobile): prevent overlapping Android thread rows #10901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions apps/mobile/src/features/threads/ThreadFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2866,13 +2866,16 @@ export const ThreadFeed = memo(function ThreadFeed(props: ThreadFeedProps) {
entry.type === "message" ? `message:${entry.message.role}` : entry.type
}
getFixedItemSize={getFixedItemSize}
// LegendList swaps its position and size component types when this
// becomes undefined, remounting the feed and replaying row entrances.
// Keep those containers mounted while ordinary updates stay immediate.
// Android's animated list containers can retain overlapping row positions
// after thread switches or app resumes, even with a zero-duration transition.
// Keep Android on native layout. On iOS, keep animated containers mounted
// between disclosure toggles so rows do not remount and replay entrances.
itemLayoutAnimation={
disclosureToggleSettling
? THREAD_FEED_LAYOUT_TRANSITION
: THREAD_FEED_IMMEDIATE_TRANSITION
Platform.OS === "android"
? undefined
: disclosureToggleSettling
? THREAD_FEED_LAYOUT_TRANSITION
: THREAD_FEED_IMMEDIATE_TRANSITION
}
onItemSizeChanged={handleItemSizeChanged}
// Measure rows well before they scroll into view so estimate→actual
Expand Down
Loading