feat(desktop): import cookies from Dia - #10813
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change adds Dia as a macOS-only Chromium browser import source. It defines Dia’s identifiers and user-data path, extends the source ID contract, and adds tests for metadata, profile discovery, cookie database resolution, installation detection, and running-state detection. ChangesDia browser import
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to This adds Dia cookie import support on macOS. The source configuration and discovery behavior are covered by focused tests and completed macOS verification, with no concrete merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Adds Dia as a macOS-only browser source using the existing Chromium cookie importer.
Automated verification:
Live macOS verification confirmed Dia detection, the running-browser guard, clean quit and lock release, and a user-completed import.
Environment isolation and clear/delete behavior were not separately exercised live; this change does not alter those existing paths.
Summary by CodeRabbit