Skip to content

feat(desktop): import cookies from Dia - #10813

Open
notsuhas wants to merge 1 commit into
pingdotgg:mainfrom
notsuhas:feat/dia-browser-cookie-import
Open

feat(desktop): import cookies from Dia#10813
notsuhas wants to merge 1 commit into
pingdotgg:mainfrom
notsuhas:feat/dia-browser-cookie-import

Conversation

@notsuhas

@notsuhas notsuhas commented Sep 8, 2026

Copy link
Copy Markdown

Adds Dia as a macOS-only browser source using the existing Chromium cookie importer.

Automated verification:

  • Focused browser-import tests: 80/80 passed
  • Contracts and desktop typechecks passed
  • Targeted lint and format checks passed
  • git diff --check passed

Live macOS verification confirmed Dia detection, the running-browser guard, clean quit and lock release, and a user-completed import.

Environment isolation and clear/delete behavior were not separately exercised live; this change does not alter those existing paths.

Summary by CodeRabbit

  • New Features
    • Added Dia as a supported browser source for cookie imports on macOS.
    • Dia now appears as an available import option when detected, including its browser profiles and cookies.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Sep 8, 2026
@notsuhas
notsuhas marked this pull request as ready for review September 8, 2026 17:48
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 00412afe-9d86-4f31-b2d9-142967dce2bc

📥 Commits

Reviewing files that changed from the base of the PR and between 12391bd and 1cc5baa.

📒 Files selected for processing (3)
  • apps/desktop/src/preview/BrowserImport/Sources.test.ts
  • apps/desktop/src/preview/BrowserImport/Sources.ts
  • packages/contracts/src/browserImport.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The change adds Dia as a macOS-only Chromium browser import source. It defines Dia’s identifiers and user-data path, extends the source ID contract, and adds tests for metadata, profile discovery, cookie database resolution, installation detection, and running-state detection.

Changes

Dia browser import

Layer / File(s) Summary
Dia source registration
packages/contracts/src/browserImport.ts, apps/desktop/src/preview/BrowserImport/Sources.ts
The source ID contract includes dia. The browser source defines Dia as a macOS-only Chromium source with its Keychain identifiers and user-data directory.
Dia source validation
apps/desktop/src/preview/BrowserImport/Sources.test.ts
Tests verify Dia metadata, platform paths, profile discovery, cookie database resolution, installation detection, and running-state detection.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 1cc5b

This adds Dia cookie import support on macOS. The source configuration and discovery behavior are covered by focused tests and completed macOS verification, with no concrete merge-blocking risk identified.

Suggested reviewers: juliusmarminge

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: adding Dia cookie import support in the desktop application.
Description check ✅ Passed The description clearly states the change and includes detailed automated and live verification results. It does not use the template headings or include the checklist, but it provides the key require…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant