fix(swift-ios): allow HTTP connections to NetBird and Tailscale IPs - #10801
Open
DominicVonk wants to merge 1 commit into
Open
fix(swift-ios): allow HTTP connections to NetBird and Tailscale IPs#10801DominicVonk wants to merge 1 commit into
DominicVonk wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The iOS app’s global App Transport Security policy now permits insecure HTTP connections to arbitrary destinations instead of only scoped local and ts.net destinations. This materially broadens the app’s default network security behavior and warrants human review. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Aligned the native Swift iOS app with the Expo app by configuring App Transport Security with only
NSAllowsArbitraryLoads = true. This replaces the narrowerNSAllowsLocalNetworkingandts.netexception configuration.Why
T3 Code users can connect to arbitrary self-hosted servers over NetBird or Tailscale, including plain HTTP endpoints at
100.*and10.*addresses or custom hostnames. The app cannot enumerate those destinations ahead of time. Matching the Expo client ensures the Swift client applies one global ATS policy to all user-configured server URLs; keepingNSAllowsLocalNetworkingwould cause modern iOS versions to ignoreNSAllowsArbitraryLoads.Checklist
Verified by parsing
apps/swift-ios/Resources/Info.plistwith Pythonplistlib, checking the ATS dictionary, runninggit diff --check, and inspecting the Xcode project settings confirmingResources/Info.plistis the app target plist. An Xcode build was not run in this Linux environment.Created with GPT-6 in the Codex harness.