Feature query interaction latency observability#1081
Feature query interaction latency observability#1081baiyuqing wants to merge 11 commits intoserverlessfrom
Conversation
Comments: - Add per-interaction latency histogram, slow interaction logging, and backend metric label GC with TTL. - Add dynamic runtime settings via config hot reload for thresholds and GC interval/TTL. - Add design doc and usage manual under docs/ for rollout, tuning, and capacity planning guidance. - Keep backward compatibility by preserving existing query duration semantics and defaulting new feature off.
- add advance.query-interaction-user-patterns with glob syntax validation - hot-reload user patterns and filter only query interaction histogram collection - use handshake/change-user usernames in command execution path, including COM_CHANGE_USER - extend docs, config examples, and add tests for config/runtime/filter behavior
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## serverless #1081 +/- ##
=============================================
Coverage ? 56.74%
=============================================
Files ? 83
Lines ? 7528
Branches ? 0
=============================================
Hits ? 4272
Misses ? 2925
Partials ? 331
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- add sql_type label to query_interaction_duration_seconds - classify COM_QUERY into select/update/begin/commit/... with other fallback - keep non-COM_QUERY commands on sql_type=other - update docs and tests for new interaction metric granularity
- enrich slow interaction logs with connection_id, interaction_time, username and sql_type - add username pattern match fields and dedicated matched-pattern warning log - expose matcher API returning matched pattern and wire connection id into cmd processor - update docs for new log events and fields
- rewrite query-interaction-latency-design.md in English - add query-interaction-latency-design-zh.md as standalone Chinese version - add README link to Chinese design doc
|
@baiyuqing: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.