-
Notifications
You must be signed in to change notification settings - Fork 412
Storage: Fix TableScan performance regression under wide-sparse table #10379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Fix TableScan performance regression under wide-sparse table #10379
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
…#10379) (#10384) close #10361 Storage: Fix TableScan performance regression under wide-sparse table * Use merged_file_info.size as the buffer size when reading data (mark, min-max index, col-data) from merged file to minimize read amplification * Use merged_file_info.size as the buffer size when parsing data as ChecksumReadBuffer to minimize the memory allocation overhead * Introduce class `MinMaxIndexLoader` to tidy codes of reading min-max index Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
What problem does this PR solve?
Issue Number: close #10361
Problem Summary:
What is changed and how it works?
test logging output: test.log.zip
Tested on x86_64 8c 32GB (m7i.2xlarge), with 16000 iops, 625MB/s throughput gp3 EBS (amd_rockylinux9)
Compare the uncompressed read/write throughput using the
dttool benchBefore this PR:
After this PR:
Compare the read/write throughput of v3 DMFile format before and after this PR:
Check List
Tests
Side effects
Documentation
Release note