-
Notifications
You must be signed in to change notification settings - Fork 412
metrics: Enhance the o11y of TiFlash storage layer #10275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: Enhance the o11y of TiFlash storage layer #10275
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
c79ab59 to
908c195
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
73354ee to
7c212ca
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
7c212ca to
b2bfcf3
Compare
|
/test pull-integration-next-gen |
|
/test pull-integration |
|
@JaySon-Huang: The specified target(s) for Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-integration-test |
|
/test pull-integration-test |
1 similar comment
|
/test pull-integration-test |
f62067a to
185fad4
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
185fad4 to
8de8ae1
Compare
| }; | ||
| using SegmentsStats = std::vector<SegmentStats>; | ||
|
|
||
| struct StoreStats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New added fields:
- column_count
- delta_cache_alloc_size
| namespace DB::DM | ||
| { | ||
|
|
||
| struct SegmentStats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New added fields:
- delta_cache_alloc_size
CalvinNeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #10272
Problem Summary:
What is changed and how it works?
New Grafana panels on TiFlash-Summary:
With the "Memory trace" panel, we can get more insight about the issue #10253 (comment) that mem-table may take too much memory.

Check List
Tests
Side effects
Documentation
Release note