expression: support newer UUID types #65007

dveeden · 2025-12-12T09:23:12Z

What problem does this PR solve?

Issue Number: close #61982

Problem Summary:

What changed and how does it work?

This adds:

UUID Generation functions for UUID v3,v4,v5,v6 and v7
Function to extract the UUID version
Function to extract the UUID timestamp

What this does not (yet) do is:

function pushdown support
A vector function for them

In other databases:

MySQL (unofficial): https://github.com/lefred/mysql-component-uuid_v7
Percona Server: https://www.percona.com/blog/all-uuid-functions-in-percona-server-for-mysql-rfc-9562-implemented/
DuckDB: https://duckdb.org/docs/stable/sql/functions/utility#uuidv7
MariaDB: https://mariadb.com/docs/server/reference/sql-functions/secondary-functions/miscellaneous-functions/uuid_v7
PostgreSQL: https://www.postgresql.org/docs/18/functions-uuid.html

Also interesting / related:

Note that there doesn't seem to be a good standard for the function names.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

More functions were added for working with UUIDs

TODO

Make sure timestamp extraction works with all applicable UUID versions
Make sure timestamp extraction gives an error for UUIDs that do not store a timestamp
Add more tests
Check if UUID_TO_BIN() and BIN_TO_UUID() actually make sense for UUID version 3-7. I assume that MySQL accepts any UUID (including those generated outside of MySQL).
Allow/Disallow the new functions in generated columns and as expression default

ti-chi-bot · 2025-12-12T09:23:16Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2025-12-12T09:23:32Z

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dveeden · 2025-12-12T09:23:46Z

/ok-to-test

codecov · 2025-12-12T11:55:55Z

Codecov Report

❌ Patch coverage is 55.79710% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.6478%. Comparing base (3455e86) to head (ff7e90c).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #65007        +/-   ##
================================================
- Coverage   70.8020%   68.6478%   -2.1543%     
================================================
  Files          1901       1879        -22     
  Lines        518502     510526      -7976     
================================================
- Hits         367110     350465     -16645     
- Misses       126860     137703     +10843     
+ Partials      24532      22358      -2174

Flag	Coverage Δ
integration	`41.6059% <55.7971%> (-6.5609%)`	⬇️
unit	`65.9143% <0.0000%> (+0.3325%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`38.4952% <ø> (-19.7346%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dveeden · 2025-12-12T12:14:05Z

/retest

purelind · 2025-12-12T20:51:45Z

/retest

dveeden · 2025-12-13T10:09:25Z

/retest

zanmato1984 · 2025-12-18T10:42:17Z

Reminder: we need to also update the doc of supported functions.

https://docs.pingcap.com/tidb/stable/miscellaneous-functions/#supported-functions

dveeden · 2025-12-18T18:24:39Z

Yes, I think v7 is probably most wanted. But with TiDB UUIDv4 might also makes sense (like AUTO_INCREMENT and AUTO_RANDOM)

V4 is fine by me too. So maybe we can limit our implementation to only v4 and v7, and preserve the flexibility to do other versions otherwise in the future? (Less code, less liability).

Yes, I've removed v3, v5 and v6 in 0ff52f2

Reminder: we need to also update the doc of supported functions.

https://docs.pingcap.com/tidb/stable/miscellaneous-functions/#supported-functions

Yes, that's on my todo list. We also need to update https://docs.pingcap.com/tidb/stable/uuid/

dveeden · 2025-12-18T20:21:54Z

/retest

pkg/expression/builtin_miscellaneous.go

dveeden · 2025-12-19T05:29:43Z

/retest

zanmato1984 · 2025-12-24T10:03:58Z

pkg/expression/builtin_miscellaneous.go

 	_ functionClass = &uuidFunctionClass{}
+	_ functionClass = &uuidv4FunctionClass{}
+	_ functionClass = &uuidv7FunctionClass{}
+	_ functionClass = &uuidVersionFunctionClass{}


Why isn't there a line for uuid_timestamp?

There should have been. I've added one and checked for more missing lines and I found a few.

diff <(grep -E '^type.*FunctionClass' pkg/expression/builtin_miscellaneous.go | sort | cut -d\ -f2) <(grep -E '_ functionClass = .*FunctionClass' pkg/expression/builtin_miscellaneous.go | sort | cut -d\& -f2 | cut -d{ -f1) diff <(grep -E '^type.*builtin' pkg/expression/builtin_miscellaneous.go | sort | cut -d\ -f2) <(grep -E '_ builtinFunc = ' pkg/expression/builtin_miscellaneous.go | sort | cut -d\& -f2 | cut -d{ -f1)

The ones that were missing:

tidbRowChecksumFunctionClass

builtinFreeLockSig

builtinNameConstVectorFloat32Sig

builtinUsedLockSig

builtinUUIDTimestampSig

builtinUUIDv4Sig

builtinUUIDv7Sig

builtinUUIDVersionSig

builtinVectorFloat32AnyValueSig

I also sorted them.

The result: 35202db

Are these lines (still) needed? What happens if they are missing?

Looks like these lines might be there to ensure these types implement functionClass etc.

However this seems to already be enforced by the reference in pkg/expression/builtin.go.

We could:

Remove these 919 lines: dveeden@af0efdb

Add GitHub action that runs checks

I think we should probably keep them and add extra github action in followup PRs. Thanks for the update!

dveeden · 2025-12-24T16:47:42Z

/retest

D3Hunter · 2025-12-24T16:49:00Z

/approve

for the parser part

D3Hunter · 2025-12-24T16:51:07Z

/hold

just to avoid accidentally merged, as I am not sure whether @zanmato1984 has finished review, you can unhold youself after fixing comments from him @dveeden

zanmato1984

LGTM.

ti-chi-bot · 2025-12-24T16:55:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, windtalker, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,GMHDBJD,windtalker,zanmato1984]
~~pkg/expression/OWNERS~~ [windtalker,zanmato1984]
~~pkg/parser/OWNERS~~ [D3Hunter]
~~pkg/table/OWNERS~~ [GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2025-12-24T16:55:52Z

/unhold

dveeden · 2025-12-24T17:08:30Z

/retest

dveeden · 2025-12-24T17:48:06Z

/retest

dveeden · 2025-12-24T18:03:44Z

Reminder: we need to also update the doc of supported functions.
https://docs.pingcap.com/tidb/stable/miscellaneous-functions/#supported-functions

Yes, that's on my todo list. We also need to update https://docs.pingcap.com/tidb/stable/uuid/

pingcap/docs#22234

dveeden requested review from fzzf678 and hawkingrei December 12, 2025 09:23

dveeden added component/expression and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025

dveeden marked this pull request as ready for review December 12, 2025 09:23

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2025

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 12, 2025

This was referenced Dec 12, 2025

UUID v7 #61982

Closed

ERROR 1305 (42000): FUNCTION UUID_SHORT does not exist #4620

Open

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025

expression: support newer UUID types

50feef1

dveeden force-pushed the uuid branch from cecf9ad to 50feef1 Compare December 12, 2025 21:12

dveeden requested review from D3Hunter, GMHDBJD, XuHuaiyu, YangKeao and zanmato1984 December 12, 2025 21:14

dveeden requested a review from windtalker December 16, 2025 09:57

Remove UUID_V3(), UUID_V5() and UUID_V6()

0ff52f2

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2025

Update TestIllegalFunctions4GeneratedColumns

cb51e33

zanmato1984 reviewed Dec 19, 2025

View reviewed changes

pkg/expression/builtin_miscellaneous.go Show resolved Hide resolved

pkg/expression/builtin_miscellaneous.go Show resolved Hide resolved

zanmato1984 reviewed Dec 24, 2025

View reviewed changes

dveeden added 2 commits December 24, 2025 17:12

Fix missing lines for uuidTimestampFunctionClass and others

35202db

Merge remote-tracking branch 'upstream/master' into uuid

ff7e90c

ti-chi-bot bot added the approved label Dec 24, 2025

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2025

zanmato1984 approved these changes Dec 24, 2025

View reviewed changes

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2025

dveeden mentioned this pull request Dec 24, 2025

Add new UUID functions pingcap/docs#22234

Open

14 tasks

ti-chi-bot bot merged commit 7dea15e into pingcap:master Dec 24, 2025
29 checks passed

This was referenced Dec 27, 2025

expression: Vectorized versions of new UUID functions #65301

Open

Add new UUID functions pingcap/tipb#384

Merged

Pushdown for UUID_VERSION() and UUID_TIMESTAMP() tikv/tikv#19253

Open

Pushdown for UUID_VERSION() and UUID_TIMESTAMP() #65348

Open

expression: support newer UUID types #65007

expression: support newer UUID types #65007

Uh oh!

Conversation

dveeden commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

TODO

Uh oh!

ti-chi-bot bot commented Dec 12, 2025

Uh oh!

tiprow bot commented Dec 12, 2025

Uh oh!

dveeden commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dveeden commented Dec 12, 2025

Uh oh!

purelind commented Dec 12, 2025

Uh oh!

dveeden commented Dec 13, 2025

Uh oh!

zanmato1984 commented Dec 18, 2025

Uh oh!

dveeden commented Dec 18, 2025

Uh oh!

dveeden commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

dveeden commented Dec 19, 2025

Uh oh!

zanmato1984 Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

zanmato1984 Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

dveeden commented Dec 24, 2025

Uh oh!

D3Hunter commented Dec 24, 2025

Uh oh!

D3Hunter commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanmato1984 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Dec 24, 2025

Uh oh!

D3Hunter commented Dec 24, 2025

Uh oh!

dveeden commented Dec 24, 2025

Uh oh!

dveeden commented Dec 24, 2025

Uh oh!

dveeden commented Dec 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

dveeden commented Dec 12, 2025 •

edited

Loading

codecov bot commented Dec 12, 2025 •

edited

Loading

D3Hunter commented Dec 24, 2025 •

edited

Loading