kafka: add throttle time metrics and grafana - #6012
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Kafka sink now exports broker throttle-time averages and p99 values through Prometheus. Three Grafana dashboards display the metric in seconds. Dashboard versions increase from 41 to 42. ChangesKafka throttle-time observability
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds Kafka throttle-time metrics and dashboard updates; no actionable merge-blocking risk remains based on the available review evidence. Sequence Diagram(s)sequenceDiagram
participant KafkaBroker
participant MetricsCollector
participant Prometheus
participant Grafana
KafkaBroker->>MetricsCollector: expose throttle-time histogram
MetricsCollector->>Prometheus: export average and p99 gauge values
Grafana->>Prometheus: query ticdc_sink_kafka_producer_throttle_time
Prometheus-->>Grafana: return broker throttle-time series
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test all |
What problem does this PR solve?
Issue Number: close #6013
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Summary by CodeRabbit
New Features
Improvements