Skip to content

Revert "kafka: decouple batch size from Kafka message size limit (#54… - #6010

Merged
ti-chi-bot[bot] merged 6 commits into
pingcap:release-8.5from
3AceShowHand:revert-decouple-max-message-bytes
Aug 17, 2026
Merged

Revert "kafka: decouple batch size from Kafka message size limit (#54…#6010
ti-chi-bot[bot] merged 6 commits into
pingcap:release-8.5from
3AceShowHand:revert-decouple-max-message-bytes

Conversation

@3AceShowHand

@3AceShowHand 3AceShowHand commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

…20) (#5772)"

This reverts commit 19ff1fc.

What problem does this PR solve?

Issue Number: close #6011

What is changed and how it works?

revert #5772

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cf186f29-a1ba-4d7c-b2e8-7d8dbbc61d68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 17, 2026
Comment thread downstreamadapter/sink/kafka/sink.go Outdated
Comment thread downstreamadapter/sink/kafka/sink.go Outdated
Comment thread downstreamadapter/sink/kafka/sink.go Outdated
Comment thread tests/integration_tests/kafka_big_messages/conf/diff_config.toml
@3AceShowHand
3AceShowHand requested a review from wk989898 August 17, 2026 06:39
@3AceShowHand

Copy link
Copy Markdown
Collaborator Author

/test all

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-17 06:50:58.145798524 +0000 UTC m=+3634044.181893570: ☑️ agreed by wk989898.
  • 2026-08-17 06:53:39.739632654 +0000 UTC m=+3634205.775727700: ☑️ agreed by lidezhu.

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 17, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 799216b into pingcap:release-8.5 Aug 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants