Skip to content

maintainer: honor balance check interval - #5979

Open
wk989898 wants to merge 3 commits into
pingcap:masterfrom
wk989898:fix-5974-balance-check-interval
Open

maintainer: honor balance check interval#5979
wk989898 wants to merge 3 commits into
pingcap:masterfrom
wk989898:fix-5974-balance-check-interval

Conversation

@wk989898

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #5974

What is changed and how it works?

The maintainer balance schedulers receive the configured check-balance-interval, but discard it and always schedule the next balance check after five seconds.
This affects both the default and redo dispatcher balance schedulers.
Use the configured next check time for every Execute exit path, including drain handling, pending scheduling work, split batching, failpoints, and normal completion.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix the maintainer balance schedulers to honor the configured check-balance-interval.

Signed-off-by: wk989898 <nhsmwk@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2026
Signed-off-by: wk989898 <nhsmwk@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@wk989898, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c22fd470-bff2-44ce-b587-247402124569

📥 Commits

Reviewing files that changed from the base of the PR and between f796ba3 and e0b7258.

📒 Files selected for processing (3)
  • coordinator/scheduler/balance.go
  • maintainer/scheduler/balance.go
  • maintainer/scheduler/balance_test.go
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 14, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, wlwilliamx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hongyunyan,wlwilliamx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-14 09:13:34.505854879 +0000 UTC m=+3383400.541949945: ☑️ agreed by wlwilliamx.
  • 2026-08-14 09:26:52.90911729 +0000 UTC m=+3384198.945212346: ☑️ agreed by hongyunyan.

Signed-off-by: wk989898 <nhsmwk@gmail.com>
@wk989898
wk989898 force-pushed the fix-5974-balance-check-interval branch from f198308 to e0b7258 Compare August 14, 2026 09:39
@wk989898

Copy link
Copy Markdown
Collaborator Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maintainer: check-balance-interval is ignored by balance schedulers

3 participants