-
Notifications
You must be signed in to change notification settings - Fork 31
go.mod: upgrade tidb and parser #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @YangKeao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine but crucial maintenance task: updating the project's Go module dependencies. The primary motivation for these upgrades is to integrate support for partial indexes into TiCDC, a feature enabled by the newer versions of the TiDB and parser modules. This ensures compatibility and leverages the latest capabilities from upstream projects. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates numerous Go module dependencies in go.mod and go.sum to newer versions. A significant concern highlighted in the review is the major version upgrade of the indirect dependency github.com/google/flatbuffers from v2.0.8+incompatible to v24.3.25+incompatible, which poses a high risk of introducing breaking changes and requires investigation into its direct cause and extensive testing.
| github.com/golang/protobuf v1.5.4 // indirect | ||
| github.com/golang/snappy v0.0.4 // indirect | ||
| github.com/google/flatbuffers v2.0.8+incompatible // indirect | ||
| github.com/google/flatbuffers v24.3.25+incompatible // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of github.com/google/flatbuffers has been upgraded from v2.0.8+incompatible to v24.3.25+incompatible. This is a very large major version jump for an indirect dependency. Such a significant upgrade carries a high risk of introducing unexpected breaking changes. It is strongly recommended to investigate which direct dependency upgrade caused this and to ensure extensive testing is in place to prevent regressions.
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
e33edd2 to
0e5f9a5
Compare
|
/check-issue-triage-complete |
What problem does this PR solve?
Issue Number: close #3698
What is changed and how it works?
Upgrade the TiCDC to support partial index.
Check List
Tests
It's manually tested with https://github.com/PingCAP-QE/endless/pull/3072.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note