Skip to content

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 18, 2025

What problem does this PR solve?

Issue Number: close #3698

What is changed and how it works?

Upgrade the TiCDC to support partial index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

It's manually tested with https://github.com/PingCAP-QE/endless/pull/3072.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign charlescheung96 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Dec 18, 2025

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @YangKeao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine but crucial maintenance task: updating the project's Go module dependencies. The primary motivation for these upgrades is to integrate support for partial indexes into TiCDC, a feature enabled by the newer versions of the TiDB and parser modules. This ensures compatibility and leverages the latest capabilities from upstream projects.

Highlights

  • Dependency Upgrades: Multiple Go module dependencies have been upgraded to their latest versions, ensuring the project uses up-to-date libraries and benefits from their improvements and bug fixes.
  • TiDB and Parser Upgrade: The core TiDB and TiDB parser modules have been specifically upgraded to enable support for partial indexes within TiCDC, addressing issue TiCDC needs to upgrade TiDB to sync partial index DDL #3698.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates numerous Go module dependencies in go.mod and go.sum to newer versions. A significant concern highlighted in the review is the major version upgrade of the indirect dependency github.com/google/flatbuffers from v2.0.8+incompatible to v24.3.25+incompatible, which poses a high risk of introducing breaking changes and requires investigation into its direct cause and extensive testing.

github.com/golang/protobuf v1.5.4 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/google/flatbuffers v2.0.8+incompatible // indirect
github.com/google/flatbuffers v24.3.25+incompatible // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version of github.com/google/flatbuffers has been upgraded from v2.0.8+incompatible to v24.3.25+incompatible. This is a very large major version jump for an indirect dependency. Such a significant upgrade carries a high risk of introducing unexpected breaking changes. It is strongly recommended to investigate which direct dependency upgrade caused this and to ensure extensive testing is in place to prevent regressions.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

/check-issue-triage-complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiCDC needs to upgrade TiDB to sync partial index DDL

1 participant